Skip to content

Conversation

@jaipaljadeja
Copy link
Member

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Adds an integration test that compares EvmRpcStream behavior with mergeGetLogsFilter="always" versus disabled by fetching block ranges from both and asserting normalized log outputs are identical; also adds a prerelease changelog metadata file for the package.

Changes

Cohort / File(s) Summary
Integration test
packages/evm-rpc/tests/merge-get-logs.integration.test.ts
New 357-line integration test creating two EvmRpcStream instances (merged vs. non-merged), constructing a logs filter and block range, fetching ranges, normalizing (sorts filterIds and blocks, sorts blocks by blockNumber/endCursor), and asserting equality.
Changelog metadata
change/...-apibara-evm-rpc-*.json
Adds a prerelease changelog entry for @apibara/evm-rpc noting a patch/merge-getLogs test comment; no API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I hopped to the chain where logs collide,
Merged and not, I hopped side by side,
I sorted each filter, each block in a line,
Then cheered when the outputs did perfectly align. 🥕✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Consider adding a brief description explaining the purpose and scope of the new merge getlogs integration test.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a merge getlogs test to the evm-rpc package.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fracek fracek merged commit d4b880a into apibara:main Jan 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants