[13.x] improveents #227
Merged
[13.x] improveents #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves exception handling by providing more detailed error messages in debug mode and refactors method signatures for clarity. Adds event dispatching to the delete method, updates findOrFail and findById logic, and reorganizes method order for better readability.
Updated the findOrFail method to throw a ResourceNotFound exception if the provided ID is null, improving error handling and preventing invalid queries.
Replaces decodeOrFail with decode and adds a type check for string values before decoding. This prevents errors when non-string values are encountered during input processing.
Mohammad-Alavi
added
type: enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 13.x #227 +/- ##
============================================
+ Coverage 88.97% 89.35% +0.37%
- Complexity 339 342 +3
============================================
Files 43 43
Lines 980 996 +16
============================================
+ Hits 872 890 +18
+ Misses 108 106 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removed redundant null check in Repository::findOrFail. Updated related test to verify exception is thrown for both non-existent and null IDs.
Reordered and refactored decode and encode methods for clarity and consistency. Updated decodeOrFail to handle multiple hash IDs more robustly and adjusted related unit tests to match new method signatures and behaviors.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs refactoring improvements to the codebase, including reorganizing method orders, enhancing error handling, and expanding test coverage for edge cases.
- Reorganized method order in HashidsManagerDecorator for better logical flow
- Enhanced error handling in Repository class with better exception messages and proper deletion events
- Expanded test coverage to include additional edge cases for hashids decoding and repository operations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Support/HashidsManagerDecorator.php | Reordered methods and improved code formatting with expanded closure syntax |
| src/Core/Repositories/Repository.php | Enhanced error handling, added proper deletion events, and improved exception messages |
| src/Core/Requests/Request.php | Changed from decodeOrFail to decode with null safety check |
| tests/Unit/Support/HashidsManagerDecoratorTest.php | Expanded test coverage for multiple hashids and edge cases |
| tests/Unit/Core/Repositories/RepositoryTest.php | Added test case for null ID in findOrFail method |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Simplified test cases for custom exception throwing in RepositoryTest and improved clarity in HashidsManagerDecoratorTest by separating exception and value assertions. This enhances test readability and maintainability.
Updated View.php to use realpath when processing view paths for more reliable normalization.
Replaces usage of Illuminate\Support\Str with PHP's basename function to extract config keys from file paths in ConfigServiceProvider. Simplifies code and removes unnecessary dependency.
Mohammad-Alavi
added
the
type: fix
Introduces a test to verify that original exception messages are returned by the repository when app debug mode is enabled, ensuring proper error reporting for resource creation and update failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve #223
resolve #224
Type of change