Tree solve multi block #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental/tree matrix
Use a compat::fma wrapper for std::fma to avoid a bug in the tree optimizer in GCC version < 8.2. See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87046 Fixes arbor-sim#568.
…sim#566) * Add gpu_context as part of execution context containing information about GPU availability, managed_memory synchronization, and atomic double availability. * Choose between ON and OFF for ARB_GPU in CMake. If ON compile for K20, K80, and P100 Note that we still need compile time information about the GPU in cuda_atomic.hpp for atomicAdd(double*, double*). This is because the function is only defined when the program is compiled for sm_60 or more.
Move implementation of `gpu_context` from header to `cpp` file, so that `ARB_WITH_CUDA` doesn't leak from library implementation.
* Add new ring benchmark to examples. * Refactored common functionality for reading miniapp parameters from a json file to `aux` (used by both bench and ring). Fixes arbor-sim#516.
if std::sort is used with a < operator that does not result in an ordering the result is wrong and contains bad data.
sort the results as the order in which the threads push their data is unknown.
qres
force-pushed
the
tree_solve_multi_block
branch
from
ccf9d96 to
b061b47
Compare
Fixes arbor-sim#575. * Guard CPU architecture option for nvcc with generator expression.
Make the execution context presented to users an opaque handle, moving all implementation of the gpu, thread and distributed contexts into the back end. * move `execution_context` and `distributed_context` definitions to the back end * create `execution_context` handle called `context` in the public API * provide `make_context` helper functions that build different context configurations (default, user-specified local resources, with MPI) * update documentation for all parts of the public API that touch contexts * move `distributed_context` docs to the developer documentation (from the public API docs)
qres
force-pushed
the
tree_solve_multi_block
branch
from
096d985 to
e5a8429
Compare
qres
force-pushed
the
tree_solve_multi_block
branch
from
ac367a4 to
aef710f
Compare
we read from `rhs[parent]` after writing to it.
so one can call the algorithms with `tree.parents()`
selecting any other root leads to wrong results. select_new_rootroot(0) will rearrange nodes such that branches which only one child branch get merged. This happens for the ring example.
qres
force-pushed
the
tree_solve_multi_block
branch
from
89a4496 to
8bf1f92
Compare
qres
force-pushed
the
tree_solve_multi_block
branch
from
8bf1f92 to
5f18da2
Compare
qres
force-pushed
the
tree_solve_multi_block
branch
from
87e54fa to
a50b9b4
Compare
qres
force-pushed
the
tree_solve_multi_block
branch
from
13a009e to
624be7f
Compare
qres
force-pushed
the
tree_solve_multi_block
branch
from
624be7f to
e7a6e99
Compare
qres
force-pushed
the
tree_solve_multi_block
branch
from
e7a6e99 to
2a92e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.