Conversation
… use strcmp and strcasecmp for comparing strings
…some HTTP downgrade attacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in 2016, I was working on a series of patches to mod_auth_cas to fix several bugs and add various features. I made some significant progress, and we started using most of my patches in our environment, but I figured I would wait until I had the whole series finished before I submitted a PR. Unfortunately, I got pulled off to another project before that happened, and my patch series was forgotten ... until we decided to upgrade to mod_auth_cas v1.2 and re-discovered this old work. Some of my old changes have already been implemented in v1.2 by other people, some of my old patches have merge conflicts with v1.2 that I haven't resolved yet, and some of my old patches are still incomplete and not ready for merging upstream ... But several patches are ready for a PR, so I figured I should open one for them before I get busy with something else and they get forgotten again.