Gt1180 record format validator #75
Conversation
- base file template for the new message validator - makes use of django app creator startapp
- within apps.py - update config to have the correct name
- Linked into the Apel RecordFactory - Doesn't make use of django model
- also cleans up some unnecessary code (unused exception handling) - validation output is also kept on submission and refresh
- has to import the apel record type classes - has an option for all, which uses the record header instead
- adds more comments - reworks exception handling - adds apel packages to requirements - adds styling - adds link to validator page onto home monitoring page
|
Oh I didn't realise the stylesheet.css file didn't already exist on GitHub. What is the reason for this? |
It exists in the |
monitoring/validator/views.py
Outdated
| } | ||
|
|
||
|
|
||
| def validate(record: str, record_type: str) -> str: |
There was a problem hiding this comment.
Not keen on functions defined inside functions. Can this just go in the outer scope after the outer function?
monitoring/templates/home.html
Outdated
|
|
||
| <h2>Record Validator</h2> | ||
| <p><ul><li> | ||
| <a href="{% url 'validator' %}">{% url 'validator' %}</a> - A validating tool to check Apel records are |
There was a problem hiding this comment.
| <a href="{% url 'validator' %}">{% url 'validator' %}</a> - A validating tool to check Apel records are | |
| <a href="{% url 'validator' %}">{% url 'validator' %}</a> - A validating tool to check APEL records are |
|
See comments above. Also, can you rebase your branch please? |
- move function definition out of other function - sort out stylesheet location error - fix APEL typo
I did as I believe you meant but my own environment was being very weird (i have 2 static folders somehow and it keeps picking up the other one) so I'm not sure if this works as expected or not, can you double check please? |
2 participants
Looks like:
Resolves GT-1190
Working towards #47