Open
Conversation
This in order to make it more accessible from more components, having the logic in one place
Owner
|
Hey all the code refactoring and functionality looks great except for two things: 1. The allowance box doesn't look all that great:I think we can just clean up the styling a little bit, but also the first box in the three boxes doesn't really apply to this page since you need to be connected. We could replace the first box with something like this: 2. The dog section is showing deposit button / contract args when it should not: |
Owner
|
One other thing I noticed, if the user doesn't have an apecoin allowance we should either disable the actions that require allowance (only deposits I think) or add an unlimited allowance as a first transaction when they try to deposit. For example the deposit button doesn't work because there is no allowance: |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





The ABIs for Mainnet and Goerli are slightly different. I made the main net one fully functional, the withdrawals are not working on Goerli.