Skip to content

Ri/make staking work#1

Open
robertistok wants to merge 61 commits intoapecollector:mainfrom
robertistok:ri/make-staking-work
Open

Ri/make staking work#1
robertistok wants to merge 61 commits intoapecollector:mainfrom
robertistok:ri/make-staking-work

Conversation

@robertistok
Copy link

@robertistok robertistok commented Jan 18, 2023

The ABIs for Mainnet and Goerli are slightly different. I made the main net one fully functional, the withdrawals are not working on Goerli.

@robertistok robertistok marked this pull request as ready for review January 31, 2023 09:45
@apecollector
Copy link
Owner

Hey all the code refactoring and functionality looks great except for two things:

1. The allowance box doesn't look all that great:

Screenshot 2023-02-02 at 9 55 26 AM

I think we can just clean up the styling a little bit, but also the first box in the three boxes doesn't really apply to this page since you need to be connected. We could replace the first box with something like this:

Screenshot 2023-02-02 at 9 55 23 AM

2. The dog section is showing deposit button / contract args when it should not:

Screenshot 2023-02-02 at 9 50 36 AM

@apecollector
Copy link
Owner

One other thing I noticed, if the user doesn't have an apecoin allowance we should either disable the actions that require allowance (only deposits I think) or add an unlimited allowance as a first transaction when they try to deposit.

For example the deposit button doesn't work because there is no allowance:

Screenshot 2023-02-02 at 2 33 44 PM

@apecollector
Copy link
Owner

I want to keep the previous address selector (the block below) on the data page and only replace it with allowance on the staking page:

Screenshot 2023-02-05 at 9 37 09 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants