Refactored to target API 28 and to use the ButterKnife library.#2
Open
danielPerez97 wants to merge 6 commits intoapbeers:developfrom
Open
Refactored to target API 28 and to use the ButterKnife library.#2danielPerez97 wants to merge 6 commits intoapbeers:developfrom
danielPerez97 wants to merge 6 commits intoapbeers:developfrom
Conversation
…ById() calls to use @BindView and ButterKnife.bind().
Owner
|
Thanks for the PR! I’ll take a look at it this weekend
… On Nov 17, 2018, at 8:11 AM, danielPerez97 ***@***.***> wrote:
Here is an overview of the ButterKnife library.
http://jakewharton.github.io/butterknife/
You can view, comment on, or merge this pull request online at:
https://github.com/apbeers/RazorbackTransit-Android/pull/2
Commit Summary
Refactored code to target Android API 28, and refactored all findViewById() calls to use @BindView and ButterKnife.bind().
File Changes
D .idea/assetWizardSettings.xml (52)
M .idea/caches/build_file_checksums.ser (0)
M .idea/misc.xml (8)
M app/build.gradle (23)
M app/src/debug/res/values/google_maps_api.xml (2)
M app/src/main/java/razorbacktransit/arcu/razorbacktransit/MainActivity.java (19)
M app/src/main/java/razorbacktransit/arcu/razorbacktransit/ParkingMapFragment.java (16)
M app/src/main/java/razorbacktransit/arcu/razorbacktransit/ViewRouteFragment.java (7)
M app/src/main/java/razorbacktransit/arcu/razorbacktransit/ViewScheduleFragment.java (9)
M build.gradle (2)
M gradle/wrapper/gradle-wrapper.properties (4)
Patch Links:
https://github.com/apbeers/RazorbackTransit-Android/pull/2.patch
https://github.com/apbeers/RazorbackTransit-Android/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Author
|
No problem! Sent you a message on Facebook as well if you want to use that as a communication outlet too. |
added 5 commits
November 27, 2018 00:02
…LiveMapFragment to be in Kotlin to use lambdas not available in Java 7.
… being prototyped through hard-coding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is an overview of the ButterKnife library.
http://jakewharton.github.io/butterknife/