Update FrameCorrector to save XY translation#16
Draft
sumiya-kuroda wants to merge 4 commits intoapasarkar:mainfrom
Draft
Update FrameCorrector to save XY translation#16sumiya-kuroda wants to merge 4 commits intoapasarkar:mainfrom
FrameCorrector to save XY translation#16sumiya-kuroda wants to merge 4 commits intoapasarkar:mainfrom
Conversation
Owner
|
Awesome @sumiya-kuroda - thanks for the contribution! It makes sense to me that frame_corrector should output the registered data + the shifts (for both piecewise rigid and rigid registration). Looks like the changes you've made do that. However, for the RegistrationArray, it's very important that it behaves exactly like an array; i.e. my_reg_array[indices] should output an array. I've included some suggestions on what might need to be done to work around that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the
FrameCorrectorobject also saves the amount of xy translation. It also supports thelazy_data_loader()class, and you can access the translation information byThis is useful when you want to save data in NWB format with
pynwb.ophys.MotionCorrectionclass.