Skip to content

Conversation

@theRobinator
Copy link

@theRobinator theRobinator commented Jan 7, 2022

The config here is the result of a meeting where we all voted for each deviation from the default style guide.

Because each codebase uses inheritance over https, this PR needs to sit open until all the relevant codebases can be updated.

To add this to your codebase:

  1. Clone this repo and check out this branch.
  2. cd into your project's directory.
  3. Run the applystyles.sh script from this PR via /path/to/applystyles.sh
  4. If the script finishes with a green line saying "no offenses", you're good! Otherwise, fix any errors that appear.
    • This may involve updating your versions of Rubocop to match the ones in API.
    • Some projects require the defunct blue_steel gem, which you can safely remove.
    • If any offenses are printed during the script's final rubocop run, you will need to manually fix them and re-run bundle exec rubocop -P to see if they disappear.
  5. Run your unit tests just in case.
  6. Make sure your .ci file has a Rubocop stage like the one in API. Optionally, you can remove the stuff about reports.

@theRobinator theRobinator requested a review from edance as a code owner January 7, 2022 18:27
@theRobinator theRobinator force-pushed the rubocop-2022 branch 5 times, most recently from 40c88fb to 0f7d7f7 Compare January 12, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants