Skip to content

[INT-109] WIP Fix Ruby 3 syntax errors #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
valeriemettler wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[INT-109] WIP Fix Ruby 3 syntax errors #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/bulk_processor/stream_encoder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def initialize(stream)
#
# @return [String] a UTF-8 encoded string
def encoded
stream.read.encode(Encoding::UTF_8, ENCODING_OPTIONS)
stream.read.encode(Encoding::UTF_8, **ENCODING_OPTIONS)
end

private
Expand Down
3 changes: 1 addition & 2 deletions lib/bulk_processor/validated_csv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def valid?
if csv.headers.any? { |header| header.nil? || header.strip == '' }
errors << MISSING_COLUMN_MESSAGE
end

errors.empty?
end

Expand All @@ -54,7 +53,7 @@ def valid?

def csv
return @csv if instance_variable_defined?('@csv')
@csv = CSV.parse(stream, PARSING_OPTIONS)
@csv = CSV.parse(stream, **PARSING_OPTIONS)
rescue NoMethodError => error
if error.message == BAD_HEADERS_ERROR_MSG
errors << MISSING_COLUMN_MESSAGE
Expand Down