Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ private CharInfo(String entitiesResource, String method, boolean internal)
*/
private boolean defineEntity(String name, char value)
{
StringBuffer sb = new StringBuffer("&");
StringBuilder sb = new StringBuilder("&");
sb.append(name);
sb.append(';');
String entityString = sb.toString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public abstract class SerializerBase
PKG_NAME = fullyQualifiedName.substring(0, lastDot);
}

StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();
for (int i = 0; i < PKG_NAME.length(); i++) {
char ch = PKG_NAME.charAt(i);
if (ch == '.')
Expand Down Expand Up @@ -1365,7 +1365,7 @@ void initCdataElems(String s)
// true if we found a URI but haven't yet processed the local name
boolean foundURI = false;

StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();
String uri = null;
String localName = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2799,7 +2799,7 @@ private void setCdataSectionElements(String key, Properties props)
Vector v = new Vector();
int l = s.length();
boolean inCurly = false;
StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();

// parse through string, breaking on whitespaces. I do this instead
// of a tokenizer so I can track whitespace inside of curly brackets,
Expand Down Expand Up @@ -2883,7 +2883,7 @@ public void setCdataSectionElements(Vector URI_and_localNames)
final int len = URI_and_localNames.size() - 1;
if (len > 0)
{
final StringBuffer sb = new StringBuffer();
final StringBuilder sb = new StringBuilder();
for (int i = 0; i < len; i += 2)
{
// whitspace separated "{uri1}local1 {uri2}local2 ..."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1289,7 +1289,7 @@ protected void firePseudoElement(String elementName)
{

if (m_tracer != null) {
StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();

sb.append('<');
sb.append(elementName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ protected void serializeDocType(DocumentType node, boolean bStart)
// DOCTYPE internal subset via an event call, so we write it
// out here.
Writer writer = fSerializer.getWriter();
StringBuffer dtd = new StringBuffer();
StringBuilder dtd = new StringBuilder();

dtd.append("<!DOCTYPE ");
dtd.append(docTypeName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1463,7 +1463,7 @@ private static String getPathWithoutEscapes(String origPath) {
if (origPath != null && origPath.length() != 0 && origPath.indexOf('%') != -1) {
// Locate the escape characters
StringTokenizer tokenizer = new StringTokenizer(origPath, "%");
StringBuffer result = new StringBuffer(origPath.length());
StringBuilder result = new StringBuilder(origPath.length());
int size = tokenizer.countTokens();
result.append(tokenizer.nextToken());
for(int i = 1; i < size; ++i) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public Object nextElement() {
}

public String toString(){
StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();
for (int i=0;i<size;i++){
buf.append(prefixes[i]);
buf.append(" ");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ private static boolean isWindowsAbsolutePath(String systemId)
*/
private static String replaceChars(String str)
{
StringBuffer buf = new StringBuffer(str);
StringBuilder buf = new StringBuilder(str);
int length = buf.length();
for (int i = 0; i < length; i++)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ public String getScheme()
public String getSchemeSpecificPart()
{

StringBuffer schemespec = new StringBuffer();
StringBuilder schemespec = new StringBuilder();

if (m_userinfo != null || m_host != null || m_port != -1)
{
Expand Down Expand Up @@ -952,7 +952,7 @@ public String getPath(boolean p_includeQueryString,
boolean p_includeFragment)
{

StringBuffer pathString = new StringBuffer(m_path);
StringBuilder pathString = new StringBuilder(m_path);

if (p_includeQueryString && m_queryString != null)
{
Expand Down Expand Up @@ -1348,7 +1348,7 @@ public boolean equals(Object p_test)
public String toString()
{

StringBuffer uriSpecString = new StringBuffer();
StringBuilder uriSpecString = new StringBuilder();

if (m_scheme != null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ public void setStylesheetParam(String key, String expr)
*/
public String escapeString(String s)
{
StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();
int length = s.length();

for (int i = 0; i < length; i++)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ else if (bestScoreCount > 1)
private static String replaceDash(String name)
{
char dash = '-';
StringBuffer buff = new StringBuffer("");
StringBuilder buff = new StringBuilder("");
for (int i=0; i<name.length(); i++)
{
if (name.charAt(i) == dash)
Expand Down Expand Up @@ -978,7 +978,7 @@ private static String errString(String callType, // "function" or "element"

private static String errArgs(Object[] xsltArgs, int startingArg)
{
StringBuffer returnArgs = new StringBuffer();
StringBuilder returnArgs = new StringBuilder();
for (int i = startingArg; i < xsltArgs.length; i++)
{
if (i != startingArg)
Expand Down
2 changes: 1 addition & 1 deletion xalan/src/main/java/org/apache/xalan/lib/ExsltBase.java
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ protected static String toString(Node n)
if (value == null)
{
NodeList nodelist = n.getChildNodes();
StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();
for (int i = 0; i < nodelist.getLength(); i++)
{
Node childNode = nodelist.item(i);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1108,7 +1108,7 @@ else if ((dateTime.length() >= 6)
private static String strip(String symbols, String pattern)
{
int i = 0;
StringBuffer result = new StringBuffer(pattern.length());
StringBuilder result = new StringBuilder(pattern.length());

while (i < pattern.length())
{
Expand Down
4 changes: 2 additions & 2 deletions xalan/src/main/java/org/apache/xalan/lib/ExsltStrings.java
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public static String align(String targetStr, String paddingStr)
*/
public static String concat(NodeList nl)
{
StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();
for (int i = 0; i < nl.getLength(); i++)
{
Node node = nl.item(i);
Expand Down Expand Up @@ -149,7 +149,7 @@ public static String padding(double length, String pattern)
if (pattern == null || pattern.length() == 0)
return "";

StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();
int len = (int)length;
int numAdded = 0;
int index = 0;
Expand Down
10 changes: 5 additions & 5 deletions xalan/src/main/java/org/apache/xalan/lib/sql/SQLQueryParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ protected void inlineParser()
{
QueryParameter curParm = null;
int state = 0;
StringBuffer tok = new StringBuffer();
StringBuilder tok = new StringBuilder();
boolean firstword = true;

if (m_Parameters == null) m_Parameters = new Vector();
Expand Down Expand Up @@ -351,7 +351,7 @@ else if ( firstword && (Character.isLetterOrDigit(ch) || ch == '#') )
}
}
firstword = false;
tok = new StringBuffer();
tok = new StringBuilder();
if ( ch == '\'' ) state = 1;
else if ( ch == '?' ) state = 4;
else state = 0;
Expand Down Expand Up @@ -379,7 +379,7 @@ else if ( tok.length() > 0 )
curParm.setTypeName(tok.toString());
// curParm.type = map_type(curParm.typeName);
m_Parameters.addElement(curParm);
tok = new StringBuffer();
tok = new StringBuilder();
if ( ch == '=' ) state = 7;
else state = 6;
}
Expand All @@ -394,7 +394,7 @@ else if ( tok.length() > 0 )
else if ( tok.length() > 0 )
{
curParm.setName(tok.toString());
tok = new StringBuffer();
tok = new StringBuilder();
if ( ch == ']' )
{
//param_output.addElement(new Boolean(false));
Expand All @@ -418,7 +418,7 @@ else if ( tok.length() > 0 )
m_hasOutput = true;
}

tok = new StringBuffer();
tok = new StringBuilder();
if ( ch == ']' )
{
state = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ else if (m_name.equals("*"))
return m_setterString;
}

StringBuffer outBuf = new StringBuffer();
StringBuilder outBuf = new StringBuilder();

outBuf.append("set");

Expand Down Expand Up @@ -643,7 +643,7 @@ Object processENUM(StylesheetHandler handler, String uri, String name,

if (retVal == StringToIntTable.INVALID_KEY)
{
StringBuffer enumNamesList = getListOfEnums();
StringBuilder enumNamesList = getListOfEnums();
handleError(handler, XSLTErrorResources.INVALID_ENUM,new Object[]{name, value, enumNamesList.toString() },null);
return null;
}
Expand Down Expand Up @@ -706,7 +706,7 @@ Object processENUM_OR_PQNAME(StylesheetHandler handler, String uri, String name,
if (objToReturn == null) objToReturn = qname;

if (qname.getPrefix() == null) {
StringBuffer enumNamesList = getListOfEnums();
StringBuilder enumNamesList = getListOfEnums();

enumNamesList.append(" <qname-but-not-ncname>");
handleError(handler,XSLTErrorResources.INVALID_ENUM,new Object[]{name, value, enumNamesList.toString() },null);
Expand All @@ -716,7 +716,7 @@ Object processENUM_OR_PQNAME(StylesheetHandler handler, String uri, String name,
}
catch (IllegalArgumentException ie)
{
StringBuffer enumNamesList = getListOfEnums();
StringBuilder enumNamesList = getListOfEnums();
enumNamesList.append(" <qname-but-not-ncname>");

handleError(handler,XSLTErrorResources.INVALID_ENUM,new Object[]{name, value, enumNamesList.toString() },ie);
Expand All @@ -725,7 +725,7 @@ Object processENUM_OR_PQNAME(StylesheetHandler handler, String uri, String name,
}
catch (RuntimeException re)
{
StringBuffer enumNamesList = getListOfEnums();
StringBuilder enumNamesList = getListOfEnums();
enumNamesList.append(" <qname-but-not-ncname>");

handleError(handler,XSLTErrorResources.INVALID_ENUM,new Object[]{name, value, enumNamesList.toString() },re);
Expand Down Expand Up @@ -1532,12 +1532,12 @@ else if (cl == Long.class)
}

/**
* StringBuffer containing comma delimited list of valid values for ENUM type.
* StringBuilder containing comma delimited list of valid values for ENUM type.
* Used to build error message.
*/
private StringBuffer getListOfEnums()
private StringBuilder getListOfEnums()
{
StringBuffer enumNamesList = new StringBuffer();
StringBuilder enumNamesList = new StringBuilder();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation looks off by one space

String [] enumValues = this.getEnumNames();

for (int i = 0; i < enumValues.length; i++)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,7 @@ String formatNumberList(
// then append the formatToken.
else if (formatTokenizer.isLetterOrDigitAhead())
{
final StringBuffer formatTokenStringBuffer = new StringBuffer(formatToken);
final StringBuilder formatTokenStringBuffer = new StringBuilder(formatToken);

// Append the formatToken string...
// For instance [2][1][5] with a format value of "1--1. "
Expand Down Expand Up @@ -1949,7 +1949,7 @@ protected String long2roman(long val, boolean prefixesAreOK)

if (val <= 3999L)
{
StringBuffer romanBuffer = new StringBuffer();
StringBuilder romanBuffer = new StringBuilder();
do
{
while (val >= m_romanConvertTable[place].m_postValue)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ String long2roman(long val, boolean prefixesAreOK)

if (val <= 3999L)
{
StringBuffer romanBuffer = new StringBuffer();
StringBuilder romanBuffer = new StringBuilder();
do
{
while (val >= m_romanConvertTable[place].m_postValue)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ protected void checkProcessorVersion(Hashtable h)
XALAN1_VERSION_CLASS, ObjectFactory.findClassLoader(), true);

// Found Xalan-J 1.x, grab it's version fields
StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();
Field f = clazz.getField("PRODUCT");

buf.append(f.get(null));
Expand Down Expand Up @@ -876,7 +876,7 @@ protected void checkProcessorVersion(Hashtable h)
XALAN2_VERSION_CLASS, ObjectFactory.findClassLoader(), true);

// Found Xalan-J 2.x, grab it's version fields
StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();
Field f = clazz.getField("S_VERSION");
buf.append(f.get(null));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public final class Compile {


public static void printUsage() {
StringBuffer vers = new StringBuffer("XSLTC version " + VERSION_MAJOR
StringBuilder vers = new StringBuilder("XSLTC version " + VERSION_MAJOR
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's weird. It should probably just use a String, or maybe use append, but really a String is all that's needed; neither StringBuilder nor StringBuffer is appropriate

+ "." + VERSION_MINOR
+ ((VERSION_DELTA > 0) ? ("." + VERSION_DELTA) : ("")));
System.err.println(vers + "\n"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public void translate(ClassGenerator classGen, MethodGenerator methodGen) {
}

public String toString() {
StringBuffer buf = new StringBuffer("attribute-set: ");
StringBuilder buf = new StringBuilder("attribute-set: ");
// Translate all local attributes
final Enumeration attributes = elements();
while (attributes.hasMoreElements()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ private void parseAVTemplate(String text, Parser parser) {
*/
String t = null;
String lookahead = null;
StringBuffer buffer = new StringBuffer();
StringBuilder buffer = new StringBuilder();
int state = OUT_EXPR;

while (tokenizer.hasMoreTokens()) {
Expand Down Expand Up @@ -216,7 +216,7 @@ public Type typeCheck(SymbolTable stable) throws TypeCheckError {
}

public String toString() {
final StringBuffer buffer = new StringBuffer("AVT:[");
final StringBuilder buffer = new StringBuilder("AVT:[");
final int count = elementCount();
for (int i = 0; i < count; i++) {
buffer.append(elementAt(i).toString());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public void translate(ClassGenerator classGen, MethodGenerator methodGen) {
il.append(methodGen.loadCurrentNode());

// Initialize prefix of method signature
StringBuffer methodSig = new StringBuffer("(" + DOM_INTF_SIG
StringBuilder methodSig = new StringBuilder("(" + DOM_INTF_SIG
+ NODE_ITERATOR_SIG + TRANSLET_OUTPUT_SIG + NODE_SIG);

// If calling a simply named template, push actual arguments
Expand Down
Loading