THRIFT-5849: Expose createClient in browser version of nodejs package#3096
Merged
Jens-G merged 1 commit intoapache:masterfrom Feb 8, 2025
Merged
Conversation
`createClient` is exposed in a nodejs context, but not for browsers. Even though this is the same function as `createWsClient`, `createHttpClient`, etc, it seems odd to use these for custom connection types. Moreover, it is beneficial for the browser and nodejs interface to be as similar as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: nodejs
createClientis exposed in a nodejs context, but not for browsers. Even though this is the same function ascreateWsClient,createHttpClient, etc, it would be better to be able to use the generic name with custom connection types. There is no reason I know of that prevents this from being exposed in a browser context - it appears to be more of an oversight.[skip ci]anywhere in the commit message to free up build resources.