Skip to content

THRIFT-5564: Add nodets tests to Github Actions#3089

Merged
Jens-G merged 1 commit intoapache:masterfrom
graphcore:nodets-tests
Feb 13, 2025
Merged

THRIFT-5564: Add nodets tests to Github Actions#3089
Jens-G merged 1 commit intoapache:masterfrom
graphcore:nodets-tests

Conversation

@cameron-martin
Copy link
Contributor

Client: nodets

This adds the tests for the "nodets" library. This isn't an actual library, and are just another set of tests for the nodejs library, but using typescript. Therefore I have added them in the existing "nodejs" job.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Client: nodets

This adds the tests for the "nodets" library. This isn't an actual library, and are just another set of tests for the nodejs library, but also using typescript. Therefore I have added them in the existing "nodejs" job.
@cameron-martin
Copy link
Contributor Author

cc @jimexist, since it seems you have been working on the conversion to GitHub actions primarily.

@Jens-G Jens-G added build and general CI cmake, automake and build system changes nodejs labels Jan 31, 2025
@Jens-G Jens-G merged commit a675c4f into apache:master Feb 13, 2025
20 of 22 checks passed
@cameron-martin cameron-martin deleted the nodets-tests branch February 14, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build and general CI cmake, automake and build system changes nodejs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants