[SPARK-54065][PYTHON][TESTS] Enable test_in_memory_data_source in Python 3.14
#52967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this, @zhengruifeng and @LuciferYang ? |
LuciferYang
approved these changes
Nov 10, 2025
Member
Author
|
Thank you, @LuciferYang ! |
Member
Author
|
Since I verified manually, let me merge this. |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 10, 2025
…ython 3.14 ### What changes were proposed in this pull request? This PR aims to enable `test_in_memory_data_source` in Python 3.14. ### Why are the changes needed? After upgrading to the latest `cloudpickle` 3.1.2, I verified that the test passed on Python 3.14.0. - #52964 ``` $ python/run-tests --parallelism 1 --testnames pyspark.sql.tests.test_python_datasource --python-executables python3 Running PySpark tests. Output is in /Users/dongjoon/APACHE/spark-merge/python/unit-tests.log Will test against the following Python executables: ['python3'] Will test the following Python tests: ['pyspark.sql.tests.test_python_datasource'] python3 python_implementation is CPython python3 version is: Python 3.14.0 Starting test(python3): pyspark.sql.tests.test_python_datasource (temp output: /Users/dongjoon/APACHE/spark-merge/python/target/e771105c-5304-4f4f-bea6-b8d896b1b250/python3__pyspark.sql.tests.test_python_datasource__2wyrv5n4.log) Finished test(python3): pyspark.sql.tests.test_python_datasource (29s) Tests passed in 29 seconds ``` ### Does this PR introduce _any_ user-facing change? No. This is a test change. ### How was this patch tested? Pass the CIs and manual tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52967 from dongjoon-hyun/SPARK-54065. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 79d0c42) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zhengruifeng
pushed a commit
that referenced
this pull request
Nov 10, 2025
…om `test_python_datasource.py` ### What changes were proposed in this pull request? This PR aims to recover CI by removing `import sys` from `test_python_datasource.py` After #52967, CI consistently fails because `sys` is no longer used. ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52970 from sarutak/followup-SPARK-54065. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
zhengruifeng
pushed a commit
that referenced
this pull request
Nov 10, 2025
…om `test_python_datasource.py` ### What changes were proposed in this pull request? This PR aims to recover CI by removing `import sys` from `test_python_datasource.py` After #52967, CI consistently fails because `sys` is no longer used. ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52970 from sarutak/followup-SPARK-54065. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 8cc76fe) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
…ython 3.14 ### What changes were proposed in this pull request? This PR aims to enable `test_in_memory_data_source` in Python 3.14. ### Why are the changes needed? After upgrading to the latest `cloudpickle` 3.1.2, I verified that the test passed on Python 3.14.0. - apache#52964 ``` $ python/run-tests --parallelism 1 --testnames pyspark.sql.tests.test_python_datasource --python-executables python3 Running PySpark tests. Output is in /Users/dongjoon/APACHE/spark-merge/python/unit-tests.log Will test against the following Python executables: ['python3'] Will test the following Python tests: ['pyspark.sql.tests.test_python_datasource'] python3 python_implementation is CPython python3 version is: Python 3.14.0 Starting test(python3): pyspark.sql.tests.test_python_datasource (temp output: /Users/dongjoon/APACHE/spark-merge/python/target/e771105c-5304-4f4f-bea6-b8d896b1b250/python3__pyspark.sql.tests.test_python_datasource__2wyrv5n4.log) Finished test(python3): pyspark.sql.tests.test_python_datasource (29s) Tests passed in 29 seconds ``` ### Does this PR introduce _any_ user-facing change? No. This is a test change. ### How was this patch tested? Pass the CIs and manual tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52967 from dongjoon-hyun/SPARK-54065. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
…om `test_python_datasource.py` ### What changes were proposed in this pull request? This PR aims to recover CI by removing `import sys` from `test_python_datasource.py` After apache#52967, CI consistently fails because `sys` is no longer used. ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52970 from sarutak/followup-SPARK-54065. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ython 3.14 ### What changes were proposed in this pull request? This PR aims to enable `test_in_memory_data_source` in Python 3.14. ### Why are the changes needed? After upgrading to the latest `cloudpickle` 3.1.2, I verified that the test passed on Python 3.14.0. - apache#52964 ``` $ python/run-tests --parallelism 1 --testnames pyspark.sql.tests.test_python_datasource --python-executables python3 Running PySpark tests. Output is in /Users/dongjoon/APACHE/spark-merge/python/unit-tests.log Will test against the following Python executables: ['python3'] Will test the following Python tests: ['pyspark.sql.tests.test_python_datasource'] python3 python_implementation is CPython python3 version is: Python 3.14.0 Starting test(python3): pyspark.sql.tests.test_python_datasource (temp output: /Users/dongjoon/APACHE/spark-merge/python/target/e771105c-5304-4f4f-bea6-b8d896b1b250/python3__pyspark.sql.tests.test_python_datasource__2wyrv5n4.log) Finished test(python3): pyspark.sql.tests.test_python_datasource (29s) Tests passed in 29 seconds ``` ### Does this PR introduce _any_ user-facing change? No. This is a test change. ### How was this patch tested? Pass the CIs and manual tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52967 from dongjoon-hyun/SPARK-54065. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…om `test_python_datasource.py` ### What changes were proposed in this pull request? This PR aims to recover CI by removing `import sys` from `test_python_datasource.py` After apache#52967, CI consistently fails because `sys` is no longer used. ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52970 from sarutak/followup-SPARK-54065. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enable
test_in_memory_data_sourcein Python 3.14.Why are the changes needed?
After upgrading to the latest
cloudpickle3.1.2, I verified that the test passed on Python 3.14.0.cloudpickleto 3.1.2 for Python 3.14 #52964Does this PR introduce any user-facing change?
No. This is a test change.
How was this patch tested?
Pass the CIs and manual tests.
Was this patch authored or co-authored using generative AI tooling?
No.