Add Spark 4 protobuf definitions and basic working #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@xuanyuanking Is this PR still WIP as mentioned in the description right? So, I marked this as draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding the changed protobuf (and new) definitions for Spark 4 this will allow us to implement the new Spark 4 capabilities. This is still a WIP
Why are the changes needed?
Spark updates things, so do we.
Does this PR introduce any user-facing change?
Yes, some interfaces will change, but for the most part user code that worked prior should still work.
How was this patch tested?
By Running the tests, but running this on windows has always been difficult to see how well it actually works.
Was this patch authored or co-authored using generative AI tooling?
No.