Skip to content

SAMZA-2804: Concurrency issues identified in run-class.sh on samza-yarn #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanthoosh merged 3 commits into from
May 2, 2025
Merged

SAMZA-2804: Concurrency issues identified in run-class.sh on samza-yarn #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ff7e41
Add annotations for each line identified as having a potential issue.
bringhurst May 1, 2025
942e0d1
Resolve multiple concurrency issues
bringhurst May 1, 2025
f34535c
Simplify comments and print manifest file locations
bringhurst May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions samza-shell/src/main/bash/run-class.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ cd $home_dir

echo "Current time: $(date '+%Y-%m-%d %H:%M:%S')"

# For example, home_dir looks like:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027
echo home_dir=$home_dir

# For example, base_dir looks like:
# /<hadoop path>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/__package
echo "framework base (location of this script). base_dir=$base_dir"

if [ ! -d "$base_dir/lib" ]; then
Expand Down Expand Up @@ -78,15 +83,23 @@ fi
# permissions for the classpath-related files when they are in their own directory. An example of where
# this is helpful is when using container images which might have predefined permissions for certain
# directories.
CLASSPATH_WORKSPACE_DIR=$base_dir/classpath_workspace

# For example, CLASSPATH_WORKSPACE_DIR looks like:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/classpath_workspace
CLASSPATH_WORKSPACE_DIR=$home_dir/classpath_workspace
mkdir -p $CLASSPATH_WORKSPACE_DIR

# file containing the classpath string; used to avoid passing long classpaths directly to the jar command
PATHING_MANIFEST_FILE=$CLASSPATH_WORKSPACE_DIR/manifest.txt
echo "Pathing manifest txt located at $PATHING_MANIFEST_FILE"

# jar file to include on the classpath for running the main class
PATHING_JAR_FILE=$CLASSPATH_WORKSPACE_DIR/pathing.jar
Copy link
Contributor

@shanthoosh shanthoosh May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we can log the pathing_jar_file path and the manifest_file path?

Copy link
Contributor Author

@bringhurst bringhurst May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

echo "Pathing manifest jar located at $PATHING_JAR_FILE"

# Newlines and spaces are intended to ensure proper parsing of manifest in pathing jar
printf "Class-Path: \n $CLASSPATH \n" > $PATHING_MANIFEST_FILE

# Creates a new archive and adds custom manifest information to pathing.jar
eval "$JAR -cvmf $PATHING_MANIFEST_FILE $PATHING_JAR_FILE"

Expand All @@ -97,12 +110,18 @@ else
fi

if [ -z "$SAMZA_LOG_DIR" ]; then
SAMZA_LOG_DIR="$base_dir"
# SAMZA_LOG_DIR will point to the symlink located at:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/logs
#
# When the symlink is resolved, this path will point to:
# /<hadoop dir>/userlogs/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027
SAMZA_LOG_DIR="$home_dir/logs"
fi

# add usercache directory
mkdir -p $base_dir/tmp
JAVA_TEMP_DIR=$base_dir/tmp
# JAVA_TEMP_DIR will point to a path similar to:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/tmp
mkdir -p $home_dir/tmp
JAVA_TEMP_DIR=$home_dir/tmp

# Check whether the JVM supports GC Log rotation, and enable it if so.
function check_and_enable_gc_log_rotation {
Expand Down
26 changes: 21 additions & 5 deletions samza-shell/src/main/bash/run-framework-class.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ cd $base_dir
base_dir=`pwd`
cd $home_dir

# Note: When using samza-yarn, home_dir looks like:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027
echo home_dir=$home_dir

# Note: When using samza-yarn, base_dir looks like:
# /<hadoop path>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/__package
echo "framework base (location of this script). base_dir=$base_dir"

if [ ! -d "$base_dir/lib" ]; then
Expand Down Expand Up @@ -107,10 +112,15 @@ fi
# permissions for the classpath-related files when they are in their own directory. An example of where
# this is helpful is when using container images which might have predefined permissions for certain
# directories.
CLASSPATH_WORKSPACE_DIR=$base_dir/classpath_workspace

# Note: When on samza-yarn, CLASSPATH_WORKSPACE_DIR looks like:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/classpath_workspace
CLASSPATH_WORKSPACE_DIR=$home_dir/classpath_workspace
mkdir -p $CLASSPATH_WORKSPACE_DIR

# file containing the classpath string; used to avoid passing long classpaths directly to the jar command
PATHING_MANIFEST_FILE=$CLASSPATH_WORKSPACE_DIR/manifest.txt

Copy link
Contributor

@shanthoosh shanthoosh May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to log the location of manifest-file and the pathing-jar-file path.

Copy link
Contributor Author

@bringhurst bringhurst May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

# jar file to include on the classpath for running the main class
PATHING_JAR_FILE=$CLASSPATH_WORKSPACE_DIR/pathing.jar

Expand All @@ -126,12 +136,18 @@ else
fi

if [ -z "$SAMZA_LOG_DIR" ]; then
SAMZA_LOG_DIR="$base_dir"
# When on samza-yarn, SAMZA_LOG_DIR will point to the symlink located at:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/logs
#
# When the symlink is resolved, this path will point to:
# /<hadoop dir>/userlogs/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027
SAMZA_LOG_DIR="$home_dir"
fi

# add usercache directory
mkdir -p $base_dir/tmp
JAVA_TEMP_DIR=$base_dir/tmp
# When on samza-yarn, JAVA_TEMP_DIR will point to a path similar to:
# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/tmp
mkdir -p $home_dir/tmp
JAVA_TEMP_DIR=$home_dir/tmp

# Check whether the JVM supports GC Log rotation, and enable it if so.
function check_and_enable_gc_log_rotation {
Expand Down
Loading