[fix][broker] Handle missing replicator during snapshot request processing#25266
Open
Denovo1998 wants to merge 1 commit intoapache:masterfrom
Open
Conversation
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
A race condition can happen when a replicated subscription snapshot request is being processed while the corresponding replicator is removed concurrently. In this case,
topic.getReplicators().get(...)may returnnull, which can lead to an exception path instead of graceful handling. This affects broker reliability under concurrent replication policy updates and marker handling.Modifications
ReplicatedSubscriptionsController#receivedSnapshotRequestfor the source-cluster replicator.startReplProducers) for non-null but disconnected replicators.ReplicatedSubscriptionsControllerTest#testSnapshotRequestWhenReplicatorRemovedConcurrentlyDoesNotThrow.replicators.get(...), removing the replicator throughPersistentTopic#removeReplicator, then resuming marker handling.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Denovo1998#22