Skip to content

[fix][meta]: fix infinity resource lock revalidation #25001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mattisonchao wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −5
Draft

[fix][meta]: fix infinity resource lock revalidation #25001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions ...ache/pulsar/metadata/LockManagerTest.java → ...ta/coordination/impl/LockManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.pulsar.metadata;
package org.apache.pulsar.metadata.coordination.impl;

import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
Expand All @@ -27,25 +27,26 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.EnumSet;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.CompletionException;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Supplier;
import lombok.Cleanup;
import org.apache.bookkeeper.discover.BookieServiceInfo;
import org.apache.pulsar.common.util.ObjectMapperFactory;
import org.apache.pulsar.metadata.api.GetResult;
import org.apache.pulsar.metadata.api.MetadataCache;
import org.apache.pulsar.metadata.api.MetadataStoreConfig;
import org.apache.pulsar.metadata.BaseMetadataStoreTest;
import org.apache.pulsar.metadata.api.*;
import org.apache.pulsar.metadata.api.MetadataStoreException.LockBusyException;
import org.apache.pulsar.metadata.api.coordination.CoordinationService;
import org.apache.pulsar.metadata.api.coordination.LockManager;
import org.apache.pulsar.metadata.api.coordination.ResourceLock;
import org.apache.pulsar.metadata.api.extended.CreateOption;
import org.apache.pulsar.metadata.api.extended.MetadataStoreExtended;
import org.apache.pulsar.metadata.coordination.impl.CoordinationServiceImpl;
import org.awaitility.Awaitility;
import org.testng.Assert;
import org.testng.annotations.Test;

public class LockManagerTest extends BaseMetadataStoreTest {
Expand Down Expand Up @@ -383,4 +384,29 @@ public void lockDeletedAndReacquired(String provider, Supplier<String> urlSuppli
assertFalse(lock.getLockExpiredFuture().isDone());
});
}

@Test(dataProvider = "impl")
public void lockDeletedAndReacquiredWithBookieInfo(String __, Supplier<String> urlSupplier) throws Exception {
@Cleanup
MetadataStoreExtended store = MetadataStoreExtended.create(urlSupplier.get(),
MetadataStoreConfig.builder().fsyncEnable(false).build());
final List<Notification> notifications = new ArrayList<>();
store.registerListener(notifications::add);
@Cleanup
CoordinationService coordinationService = new CoordinationServiceImpl(store);
@Cleanup
LockManager<BookieServiceInfo> lockManager = coordinationService.getLockManager(BookieServiceInfo.class);
String key = newKey();
ResourceLockImpl<BookieServiceInfo> lock = (ResourceLockImpl<BookieServiceInfo>)lockManager.acquireLock(key, new BookieServiceInfo()).join();
lock.silentRevalidateOnce().join();
// wait for 1 sec
Thread.sleep(1000);

Assert.assertEquals(notifications.size(), 1);
final Notification notification = notifications.get(0);
Assert.assertEquals(notification.getType(), NotificationType.Created);
Assert.assertEquals(notification.getPath(), key);

}

}
Loading