[fix][test] Fix IllegalArgumentException in bucket range validation for delayed message delivery#24620
Closed
Denovo1998 wants to merge 2 commits intoapache:masterfrom
Closed
[fix][test] Fix IllegalArgumentException in bucket range validation for delayed message delivery#24620Denovo1998 wants to merge 2 commits intoapache:masterfrom
Denovo1998 wants to merge 2 commits intoapache:masterfrom
Conversation
|
@Denovo1998 Please add the following content to your PR description and select a checkbox: |
15 tasks
Member
Is single threaded usage guaranteed within Pulsar? IIRC, there might be one thread performing an operation at a time, but Pulsar dispatchers execute on different threads depending on the scenario. |
Member
|
@Apurva007 Please review |
Contributor
Author
|
May be addressed in #24739 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24578
Main Issue: #xyz
PIP: #xyz
Motivation
Fixed race conditions in thread safety tests that were causing intermittent IllegalReferenceCountException failures due to improper resource cleanup order and unrealistic concurrent write patterns.
Modifications
usage patterns where addMessage is called sequentially
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Denovo1998#9