[fix][broker] Fix failed topic future not removed before the deduplication recovery is done #24500
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.bookkeeper.mledger.util; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import org.apache.bookkeeper.mledger.AsyncCallbacks; | ||
| import org.apache.bookkeeper.mledger.Entry; | ||
| import org.apache.bookkeeper.mledger.ManagedCursor; | ||
| import org.apache.bookkeeper.mledger.ManagedLedger; | ||
| import org.apache.bookkeeper.mledger.ManagedLedgerException; | ||
| import org.apache.bookkeeper.mledger.Position; | ||
| import org.apache.pulsar.common.classification.InterfaceStability; | ||
|
|
||
| /** | ||
| * This util class contains some future-based methods to replace callback-based APIs. With a callback-based API, if any | ||
| * exception is thrown in the callback, the callback will never have a chance to be called. While with a future-based | ||
| * API, if any exception is thrown in future's callback (e.g. `thenApply`), the future will eventually be completed | ||
| * exceptionally. In addition, future-based API is easier for users to switch a different executor to execute the | ||
| * callback (e.g. `thenApplyAsync`). | ||
| */ | ||
| @InterfaceStability.Evolving | ||
| public class ManagedLedgerAsyncUtils { | ||
|
|
||
| public static CompletableFuture<ManagedCursor> openCursor(ManagedLedger ml, String cursorName) { | ||
| final var future = new CompletableFuture<ManagedCursor>(); | ||
| ml.asyncOpenCursor(cursorName, new AsyncCallbacks.OpenCursorCallback() { | ||
| @Override | ||
| public void openCursorComplete(ManagedCursor cursor, Object ctx) { | ||
| future.complete(cursor); | ||
| } | ||
|
|
||
| @Override | ||
| public void openCursorFailed(ManagedLedgerException exception, Object ctx) { | ||
| future.completeExceptionally(exception); | ||
| } | ||
| }, null); | ||
| return future; | ||
| } | ||
|
|
||
| public static CompletableFuture<List<Entry>> readEntries(ManagedCursor cursor, int numberOfEntriesToRead, | ||
| Position maxPosition) { | ||
| final var future = new CompletableFuture<List<Entry>>(); | ||
| cursor.asyncReadEntries(numberOfEntriesToRead, new AsyncCallbacks.ReadEntriesCallback() { | ||
| @Override | ||
| public void readEntriesComplete(List<Entry> entries, Object ctx) { | ||
| future.complete(entries); | ||
| } | ||
|
|
||
| @Override | ||
| public void readEntriesFailed(ManagedLedgerException exception, Object ctx) { | ||
| future.completeExceptionally(exception); | ||
| } | ||
| }, null, maxPosition); | ||
| return future; | ||
| } | ||
|
|
||
| public static CompletableFuture<Void> markDelete(ManagedCursor cursor, Position position, | ||
| Map<String, Long> properties) { | ||
| final var future = new CompletableFuture<Void>(); | ||
| cursor.asyncMarkDelete(position, properties, new AsyncCallbacks.MarkDeleteCallback() { | ||
| @Override | ||
| public void markDeleteComplete(Object ctx) { | ||
| future.complete(null); | ||
| } | ||
|
|
||
| @Override | ||
| public void markDeleteFailed(ManagedLedgerException exception, Object ctx) { | ||
| future.completeExceptionally(exception); | ||
| } | ||
| }, new Object()); | ||
| return future; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary change of #22860 is to remove the failed Future case by case instead of removing a failed topic creation future here.
@shibd @codelipenghui Could you also review the current PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I explained all details in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key point:
#24497 is the best example. #23184 is another example before.
The main concern is that if an orphan pending
PersistentTopiccould affect the new pendingPersistentTopic, mainly due to:Even if it could make the new
PersistentTopicfail to load, it will be the same with the existing case, with better exception message (e.g.replicator create failure) rather than the misleading timeout exception (Failed to load topic within timeout).