Skip to content

[improve][test] Default-enable bk http in test setup#24375

Closed
nodece wants to merge 1 commit intoapache:masterfrom
nodece:enable-http-for-bk-test
Closed

[improve][test] Default-enable bk http in test setup#24375
nodece wants to merge 1 commit intoapache:masterfrom
nodece:enable-http-for-bk-test

Conversation

@nodece
Copy link
Member

@nodece nodece commented Jun 3, 2025

Motivation

bk http is an important feature. During bk upgrades, the http server may stop working unexpectedly.
A similar issue occurred in #20070, which didn't include tests to cover bk http functionality.

Modifications

  • Enabled bk http by default in the test configuration to ensure the http server is started and functional.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 3, 2025
@lhotari
Copy link
Member

lhotari commented Jun 3, 2025

  • Enabled bk http by default in the test configuration to ensure the http server is started and functional.

@nodece Are you planning to add a test case that also verifies that it actually works?

@nodece
Copy link
Member Author

nodece commented Jun 3, 2025

@lhotari Closed by #20149, which includes these changes.

@nodece nodece closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants