[fix][ml] Fix ManagedCursorImpl.individualDeletedMessages concurrent issue

[dao-jun]

Motivation

Fix ManagedCursorImpl.individualDeletedMessages concurrent issue.

2025-05-22T13:16:55,588 - INFO  - [PulsarTestContext-executor-OrderedExecutor-0-0:PulsarMockBookKeeper] - Creating ledger 6
2025-05-22T13:16:55,592 - WARN  - [PulsarTestContext-executor-OrderedExecutor-0-0:ManagedCursorImpl] - [my-property/my-ns/persistent/my-topic1]-my-subscriber-name Failed to serialize individualDeletedMessages
java.lang.ArrayIndexOutOfBoundsException: Index 2 out of bounds for length 2
	at org.roaringbitmap.ArrayContainer.copyBitmapTo(ArrayContainer.java:1136) ~[RoaringBitmap-1.2.0.jar:?]
	at org.roaringbitmap.BitSetUtil.toLongArray(BitSetUtil.java:94) ~[RoaringBitmap-1.2.0.jar:?]
	at org.roaringbitmap.RoaringBitSet.toLongArray(RoaringBitSet.java:216) ~[RoaringBitmap-1.2.0.jar:?]
	at org.apache.pulsar.common.util.collections.OpenLongPairRangeSet.lambda$toRanges$5(OpenLongPairRangeSet.java:266) ~[classes/:?]
	at java.base/java.util.concurrent.ConcurrentSkipListMap.forEach(ConcurrentSkipListMap.java:3030) ~[?:?]
	at org.apache.pulsar.common.util.collections.OpenLongPairRangeSet.toRanges(OpenLongPairRangeSet.java:262) ~[classes/:?]
	at org.apache.bookkeeper.mledger.impl.RangeSetWrapper.toRanges(RangeSetWrapper.java:151) ~[classes/:?]
	at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.persistPositionToLedger(ManagedCursorImpl.java:3263) ~[classes/:?]
	at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.lambda$createNewMetadataLedger$37(ManagedCursorImpl.java:3067) ~[classes/:?]
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire$$$capture(CompletableFuture.java:718) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147) ~[?:?]
	at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.lambda$doCreateNewMetadataLedger$39(ManagedCursorImpl.java:3115) ~[classes/:?]

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (bbc6224) to head (ec7277d).
Report is 1116 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #24338      +/-   ##
============================================
+ Coverage     73.57%   74.24%   +0.67%     
+ Complexity    32624    32257     -367     
============================================
  Files          1877     1866      -11     
  Lines        139502   145126    +5624     
  Branches      15299    16593    +1294     
============================================
+ Hits         102638   107753    +5115     
+ Misses        28908    28854      -54     
- Partials       7956     8519     +563     

Flag	Coverage Δ
inttests	26.79% <50.00%> (+2.21%)	⬆️
systests	23.23% <50.00%> (-1.09%)	⬇️
unittests	73.72% <100.00%> (+0.87%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java	79.12% <100.00%> (-0.17%)	⬇️

... and 1086 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lhotari]

@dao-jun It looks like there are multiple other concurrency issues introduced by #9292 changes. Would you like to cover all locations where individualDeletedMessages is accessed. Since the class isn't thread safe, either the read lock or write lock should be used for all accesses.

[lhotari]

@dao-jun it seems that the only other location is in recoverIndividualDeletedMessages method.

[lhotari]

please also handle the concurrency issue in recoverIndividualDeletedMessages method. A write lock would be needed there.

[dao-jun]

please also handle the concurrency issue in recoverIndividualDeletedMessages method. A write lock would be needed there.

fixed

[dao-jun]

related to #22966

[lhotari]

LGTM