Skip to content

[improve][ci] Upgrade/Downgrade test#22988

Merged
dlg99 merged 2 commits intoapache:masterfrom
dlg99:downgrade-test
Oct 8, 2024
Merged

[improve][ci] Upgrade/Downgrade test#22988
dlg99 merged 2 commits intoapache:masterfrom
dlg99:downgrade-test

Conversation

@dlg99
Copy link
Contributor

@dlg99 dlg99 commented Jun 28, 2024

Motivation

catch issues like #22051

Modifications

Added a test for upgrade/downgrade

Verifying this change

  • Make sure that the change passes the CI checks.

This change adds tests.

Does this pull request potentially affect one of the following parts:

NO

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dlg99#18

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 28, 2024
@dlg99 dlg99 requested review from hangc0276 and lhotari June 28, 2024 16:17
@dlg99
Copy link
Contributor Author

dlg99 commented Sep 3, 2024

@lhotari ping

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dlg99, this is very useful. I have provided review feedback to make this more generic and usable in maintenance branches.

@lhotari lhotari added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Sep 27, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @dlg99

@lhotari lhotari added this to the 4.0.0 milestone Oct 4, 2024
@lhotari lhotari changed the title [improve] Upgrade/Downgrade test [improve][ci] Upgrade/Downgrade test Oct 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (bbc6224) to head (30b5271).
Report is 649 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22988      +/-   ##
============================================
+ Coverage     73.57%   74.54%   +0.97%     
- Complexity    32624    33934    +1310     
============================================
  Files          1877     1937      +60     
  Lines        139502   145433    +5931     
  Branches      15299    15897     +598     
============================================
+ Hits         102638   108414    +5776     
+ Misses        28908    28688     -220     
- Partials       7956     8331     +375     
Flag Coverage Δ
inttests 27.75% <ø> (+3.17%) ⬆️
systests 24.56% <ø> (+0.23%) ⬆️
unittests 73.88% <ø> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 616 files with indirect coverage changes

@dlg99 dlg99 merged commit 9579c4d into apache:master Oct 8, 2024
+ "chmod -R ug+rwx /pulsar/data && "
+ "chown -R 10000:0 /pulsar/data && "
+ "rm -rf /pulsar/data/* && "
+ "while true; do echo \"$MAGIC_NUMBER\" | nc -l -p 80; done");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this command?

hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test release/blocker Indicate the PR or issue that should block the release until it gets resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants