Skip to content

[improve][broker] perf: Reduce stickyHash calculations of non-persistent topics in SHARED subscriptions#22536

Merged
dlg99 merged 1 commit intoapache:masterfrom
dlg99:apache-nonpersistent_keyhash
Apr 26, 2024
Merged

[improve][broker] perf: Reduce stickyHash calculations of non-persistent topics in SHARED subscriptions#22536
dlg99 merged 1 commit intoapache:masterfrom
dlg99:apache-nonpersistent_keyhash

Conversation

@dlg99
Copy link
Contributor

@dlg99 dlg99 commented Apr 18, 2024

Motivation

perf optimization

Modifications

do not repeat StickyKeyHash calculations twice

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

NO

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dlg99#15

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 18, 2024
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlg99 dlg99 merged commit bf5d6aa into apache:master Apr 26, 2024
@nicoloboschi nicoloboschi modified the milestones: 3.4.0, 3.3.0 May 20, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/broker doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants