[fix][sql] Remove useless configuration for Pulsar SQL#20605
Merged
Technoboy- merged 3 commits intoapache:masterfrom Jun 29, 2023
Merged
[fix][sql] Remove useless configuration for Pulsar SQL#20605Technoboy- merged 3 commits intoapache:masterfrom
Technoboy- merged 3 commits intoapache:masterfrom
Conversation
Technoboy-
approved these changes
Jun 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20605 +/- ##
============================================
+ Coverage 72.29% 72.71% +0.42%
- Complexity 31951 32305 +354
============================================
Files 1854 1867 +13
Lines 138462 140417 +1955
Branches 15221 15427 +206
============================================
+ Hits 100095 102106 +2011
+ Misses 30384 30249 -135
- Partials 7983 8062 +79
Flags with carried forward coverage won't be shown. Click here to find out more. |
poorbarcode
approved these changes
Jun 29, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jun 29, 2023
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jun 29, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #14506, we remove the useless config
managedLedgerNumWorkerThreadsbut we didn't remove the config from the config file, if users use this configuration, the Pulsar SQL can't startup due to
strictConfigmode, remove this useless configuration for Pulsar SQL.Modifications
Remove useless configuration
pulsar.managed-ledger-num-worker-threadsfrom the config file.Verifying this change
Add tests for the annotated configurations.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: gaoran10#28