[fix][broker] Fix the thread safety issue of BrokerData#getTimeAverageData access#19889
Merged
lordcheng10 merged 1 commit intoapache:masterfrom Mar 27, 2023
Merged
Conversation
lordcheng10
changed the title
AnonHxy
approved these changes
Mar 23, 2023
Technoboy-
approved these changes
Mar 24, 2023
Technoboy-
pushed a commit
that referenced
this pull request
May 9, 2023
…eData access (#19889) Co-authored-by: lordcheng10 <leolinchen@tencent.com>
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jul 23, 2024
…eData access (apache#19889) Co-authored-by: lordcheng10 <leolinchen@tencent.com> (cherry picked from commit 19c8497)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 24, 2024
…eData access (apache#19889) Co-authored-by: lordcheng10 <leolinchen@tencent.com> (cherry picked from commit 19c8497)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the updateBundleData method, when the following code is executed:
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
Lines 591 to 592 in 30d2469
In the reset method, information such as longTermMsgRateIn will be recalculated:
At this time, if brokerData.getTimeAverageData() is called in the LeastLongTermMessageRate#getScore method, the calculated score will be inaccurate：
Modifications
Create a new TimeAverageBrokerData object and perform a reset update. After the update is complete, call setTimeAverageData:
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lordcheng10#45