[fix][io] KCA: Option to use kafka connector's SourceConnector class to create task and task config#19772
Merged
eolivelli merged 2 commits intoapache:masterfrom Mar 10, 2023
Merged
Conversation
…task and task config
dlg99
changed the title
eolivelli
requested changes
Mar 10, 2023
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Great work
There is an import to be removed before committing the patch
| import org.apache.pulsar.common.schema.KeyValue; | ||
| import org.apache.pulsar.functions.api.Record; | ||
| import org.apache.pulsar.io.core.SourceContext; | ||
| import org.jetbrains.annotations.NotNull; |
Contributor
There was a problem hiding this comment.
This was added by the IDE.
We should remove it before committing
Contributor
|
@dlg99 I would like to cherry-pick this patch to branch-2.11 and to branch-2.10, but the patch doesn't apply. Could you please send a new PR ? or maybe there are dependencies that we are missing ? |
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Mar 10, 2023
…to create task and task config (apache#19772) (cherry picked from commit 90b0f0a)
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Mar 10, 2023
…to create task and task config (apache#19772) (cherry picked from commit 90b0f0a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
KCA's SourceConnector uses Kafka's task name as a parameter and creates the task directly.
this works well enough for simpler or old sources (e.g. debezium's postgre/mysql/mongo etc).
Actual expected life cycle is to create a connector, then get the task class and the task config from it.
Connectors that rely on such cycle do not work with KCA, e.g. yugabyte's debezium source. See
https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1677506713032549 for details.
Modifications
Added option to pass source connector's class name, made use of it.
Kept the KCA compatible with old configuration, falling back to the legacy behavior if the config is not set.
Verifying this change
This change added unit test.
Does this pull request potentially affect one of the following parts:
NO
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dlg99#11