fix: fix extra volumes indentation for rendering the helm chart properly#656
Merged
lhotari merged 1 commit intoapache:masterfrom Feb 24, 2026
Merged
fix: fix extra volumes indentation for rendering the helm chart properly#656lhotari merged 1 commit intoapache:masterfrom
lhotari merged 1 commit intoapache:masterfrom
Conversation
Member
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #651
Motivation
The goal is to fix a indentation issue causing the dekaf deployment helm template not to render properly when setting extra volumes, this is useful when you mount a jwt token for authenticating with dekaf
Modifications
Set the identation from 8 to 6
Verifying this change
Go to
pulsar-helm-chart/charts/pulsarCreate test-values.yaml:
Running
helm template pulsar . -f test-values.yaml --show-only templates/dekaf-deployment.yamlrenders properly