Skip to content

fix: fix extra volumes indentation for rendering the helm chart properly#656

Merged
lhotari merged 1 commit intoapache:masterfrom
soyji:fix/dekaf-indentation
Feb 24, 2026
Merged

fix: fix extra volumes indentation for rendering the helm chart properly#656
lhotari merged 1 commit intoapache:masterfrom
soyji:fix/dekaf-indentation

Conversation

@soyji
Copy link
Contributor

@soyji soyji commented Feb 24, 2026

Fixes #651

Motivation

The goal is to fix a indentation issue causing the dekaf deployment helm template not to render properly when setting extra volumes, this is useful when you mount a jwt token for authenticating with dekaf

Modifications

Set the identation from 8 to 6

Verifying this change

Go to pulsar-helm-chart/charts/pulsar

Create test-values.yaml:

components:
  dekaf: true

dekaf:
  persistence:
    storageClass: "gp3"
  deployment:
    extraEnv:
    - name: DEKAF_PUBLIC_BASE_URL
      value: "http://dekaf-int-dev.test.com"
    extraVolumeMounts:
      - name: admin-token
        mountPath: /pulsar/tokens/admin
        readOnly: true
    extraVolumes:
      - name: admin-token
        secret:
          secretName: pulsar-token-admin

Running helm template pulsar . -f test-values.yaml --show-only templates/dekaf-deployment.yaml renders properly

@lhotari lhotari merged commit 4d4a41c into apache:master Feb 24, 2026
35 checks passed
@lhotari
Copy link
Member

lhotari commented Feb 24, 2026

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indentation issue in dekaf deployment helm template

2 participants