feat(fix): switch console to direct server API calls with CORS #147
+66
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
binarycat0
commented
Jan 28, 2026
binarycat0
commented
- Removed Vite dev server proxy configuration
- Removed nginx proxy from Docker setup
- Updated API client to use absolute URLs
- Updated README with Quarkus CORS configuration options
- Removed Vite dev server proxy configuration - Removed nginx proxy from Docker setup - Updated API client to use absolute URLs - Updated README with Quarkus CORS configuration options
dimas-b
reviewed
Jan 28, 2026
| // This avoids CORS issues by proxying requests through the server | ||
| // The server.ts proxy handles /api routes in production, and Vite handles them in development | ||
| const TOKEN_URL = "/api/catalog/v1/oauth/tokens" | ||
| const TOKEN_URL = `${config.POLARIS_API_URL}/api/catalog/v1/oauth/tokens` |
There was a problem hiding this comment.
nit: this whole endpoint is deprecated in the Iceberg REST API spec, which is apparently what defines the URI suffix here.
I believe it is preferable to make the whole URI configurable and avoid assuming a particular suffix.
Since it's not a material change in this PR, this can be addressed later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.