TEPHRA-265 Fix NOTICE_BINARY for Guice and Guice Assisted Inject libraries#63
TEPHRA-265 Fix NOTICE_BINARY for Guice and Guice Assisted Inject libraries#63gokulavasan wants to merge 1 commit intoapache:masterfrom
Conversation
|
@johnament Please review this PR that fixes the NOTICE file for Apache Tephra when you get a chance. Thank you! |
tephra-distribution/NOTICE_BINARY
Outdated
| This product includes software developed at | ||
| The Apache Software Foundation (http://www.apache.org/). | ||
|
|
||
| Apache Tephra includes Guava v13.0.1. Tephra elects to include this software |
There was a problem hiding this comment.
most of these lines are still not relevant.
There was a problem hiding this comment.
@johnament Should I remove these lines? I couldn't find a NOTICE in Guava, Gson, javax.inject JARs.
There was a problem hiding this comment.
Just because a dependency is apache licensed doesn't mean it will have a NOTICE. NOTICE is optional, so you shouldn't include one if none is present.
|
@gokulavasan Do you have time to take this PR to completion? |
gokulavasan
force-pushed
the
feature/tephra-notice-fix
branch
from
4c942c5 to
d119b99
Compare
|
@johnament Thanks for the review John. Please take another look when you get a chance. |
|
@johnament We are planning for the next release of Tephra soon. Can you take a look at the changes, so that this PR can be part of the next release? |
3 participants
JIRA : https://issues.apache.org/jira/browse/TEPHRA-265