Skip to content

Conversation

@pjfanning
Copy link
Member

No description provided.

<groupId>org.apache.pekko</groupId>
<artifactId>pekko-sample-cluster-kubernetes-java</artifactId>
<version>${version.number}</version>
<version>0.1.0</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI build due to the old value - maybe mvn is now stricter about version numbers based on tokens

+ mvn clean package docker:build
[INFO] Scanning for projects...
Error: ] Some problems were encountered while processing the POMs:
Warning:  'version' contains an expression but should be a constant. @ org.apache.pekko:pekko-sample-cluster-kubernetes-java:${version.number}, /home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml, line 5, column 12
Error:  'version' must be a constant version but is '${git.commit.time}-${git.commit.id.abbrev}'. @ org.apache.pekko:pekko-sample-cluster-kubernetes-java:${version.number}, /home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml, line 5, column 12
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project org.apache.pekko:pekko-sample-cluster-kubernetes-java:${git.commit.time}-${git.commit.id.abbrev} (/home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml) has 1 error
Error:      'version' must be a constant version but is '${git.commit.time}-${git.commit.id.abbrev}'. @ org.apache.pekko:pekko-sample-cluster-kubernetes-java:${version.number}, /home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml, line 5, column 12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make it a -SNAPSHOT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to 0.1.0-SNAPSHOT

<groupId>org.apache.pekko</groupId>
<artifactId>pekko-sample-cluster-kubernetes-java</artifactId>
<version>${version.number}</version>
<version>0.1.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make it a -SNAPSHOT?

@pjfanning pjfanning merged commit bf38924 into apache:main Jun 14, 2025
2 checks passed
@pjfanning pjfanning deleted the upgrade-deps branch June 14, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants