Skip to content

fix: stabilize NonBalancingIntegrationSpec to avoid port-reuse flakiness #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
He-Pin merged 1 commit into from
Mar 8, 2026
Merged

fix: stabilize NonBalancingIntegrationSpec to avoid port-reuse flakiness #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions ...rop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/NonBalancingIntegrationSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,20 +87,15 @@ class NonBalancingIntegrationSpec(backend: String)

Future.sequence(requestsOnFirstConnection).futureValue
server1.terminate(5.seconds).futureValue
// Give it some time to complete unbind (suspected to cause test flakyness)
Thread.sleep(250)
// And restart
Http().newServerAt("127.0.0.1", server1.localAddress.getPort).bind(GreeterServiceHandler(service1)).futureValue

val requestsOnSecondConnection = List.fill(requestsPerConnection)(client.sayHello(HelloRequest(s"Hello")))

val replies = Future.sequence(requestsOnSecondConnection)
Await.ready(replies, 15.seconds)

if (this.isInstanceOf[NonBalancingIntegrationSpecNetty] && service1.greetings.get != numberOfRequests) {
system.log.warning(
s"Found only ${service1.greetings.get} requests rather than $numberOfRequests, likely a flaky test")
pending
} else
service1.greetings.get should be(numberOfRequests)
Future.sequence(requestsOnSecondConnection).futureValue(timeout(15.seconds))
service1.greetings.get should be(numberOfRequests)
}

"re-discover endpoints on failure" in {
Expand Down
Loading