build: remove hardcoded Scala 2.12 version from gen-scala-server scripted tests; add scala-2_13 test suite#649
Draft
He-Pin wants to merge 3 commits intoapache:mainfrom
Draft
build: remove hardcoded Scala 2.12 version from gen-scala-server scripted tests; add scala-2_13 test suite#649He-Pin wants to merge 3 commits intoapache:mainfrom
He-Pin wants to merge 3 commits intoapache:mainfrom
Conversation
…pted tests and add scala-2_13 test suite Remove the obsolete `scalaVersion := "2.12.20"` pin (and the stale "Can be removed when we move to 2.12.14" comment) from all eleven gen-scala-server scripted-test `build.sbt` files. These tests run under the Scala version selected by the sbt-plugin project (currently 2.12), so the explicit pin is redundant and creates maintenance noise. Add a new scripted-test directory `sbt-plugin/src/sbt-test/scala-2_13/` with a basic client-server test that explicitly sets `scalaVersion := "2.13.16"`. This mirrors the existing `scala3/01-basic-client-server` scripted test and gives us a dedicated Scala 2.13 smoke-test for the sbt plugin, verifying that PekkoGrpcPlugin works correctly under 2.13 (in addition to the default 2.12 scripted run and the existing Scala 3 suite). Upstream commit: akka/akka-grpc@ff09d8fa Upstream PR: akka/akka-grpc#1715 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pjfanning
reviewed
Mar 8, 2026
sbt-plugin/src/sbt-test/scala-2_13/01-basic-client-server/build.sbt
Outdated
Show resolved
Hide resolved
- Add scalaVersion := "2.13.18" to gen-scala-server scripted tests that were missing it (02-05, 09, 11), preventing Scala 2.12 fallback that caused pekko-grpc-runtime_2.12 resolution failures - Format 07-gen-basic-server-with-pekko/build.sbt to align case x with other pattern match arms (scalafmt 3.10.7 compatibility) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…3 test from 2.13.16 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Multiple
gen-scala-serverscripted testbuild.sbtfiles contained a hardcodedscalaVersion := "2.12.x". This prevented the sbt scripted plugin from running them under Scala 2.13, even when the CI matrix passed a 2.13 version.Modification
scalaVersionsettings from 11sbt-plugin/src/sbt-test/gen-scala-server/*/build.sbtfiles so they pick up the version provided by the scripted runnersbt-plugin/src/sbt-test/scala-2_13/01-basic-client-server/scripted test directory that mirrors thegen-scala-server/01-basic-client-servertest without any Scala version pinningResult
The scripted tests are now version-agnostic and run under whichever Scala version the sbt scripted runner provides, enabling 2.12/2.13 cross-version CI coverage without separate test sets.
References