Skip to content

chore: replace per-site @nowarn with scoped -Wconf in codegen #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
He-Pin wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: replace per-site @nowarn with scoped -Wconf in codegen #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions codegen/src/main/scala/org/apache/pekko/grpc/gen/CodeGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

package org.apache.pekko.grpc.gen

import scala.annotation.nowarn
import com.google.protobuf.ExtensionRegistry
import com.google.protobuf.compiler.PluginProtos.CodeGeneratorRequest
import com.google.protobuf.compiler.PluginProtos.CodeGeneratorResponse
Expand All @@ -33,7 +32,7 @@ trait CodeGenerator {
/** Takes Scala binary version and returns suggested dependency Seq */
def suggestedDependencies: ScalaBinaryVersion => Seq[Artifact]

def registerExtensions(@nowarn("msg=is never used") registry: ExtensionRegistry): Unit = {}
def registerExtensions(registry: ExtensionRegistry): Unit = {}

final def run(request: Array[Byte], logger: Logger): Array[Byte] = {
val registry = ExtensionRegistry.newInstance
Expand Down
3 changes: 3 additions & 0 deletions project/Common.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ object Common extends AutoPlugin {
Seq(
// Generated code for methods/fields marked 'deprecated'
"-Wconf:msg=Marked as deprecated in proto file:silent",
// Suppress "parameter X is never used" in CodeGenerator's registerExtensions
// default trait impl. Uses precise path+msg filter to avoid masking real warnings.
"-Wconf:src=.*/grpc/gen/CodeGenerator\\.scala:msg=is never used:silent",
// ignore imports in templates (FIXME why is that trailing .* needed?)
"-Wconf:src=.*.txt.*:silent",
"-Wconf:cat=unused-nowarn:silent")
Expand Down
Loading