Add request URI to gRPC client error descriptions#646
Open
pjfanning wants to merge 2 commits intoapache:mainfrom
Open
Add request URI to gRPC client error descriptions#646pjfanning wants to merge 2 commits intoapache:mainfrom
pjfanning wants to merge 2 commits intoapache:mainfrom
Conversation
…PR #1748) Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
raboof
reviewed
Mar 6, 2026
Member
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
I'm not so sure. I share some of the concerns from the original issue that this could leak internal information or give the client control over the response in a way that could lead to XSS-type situations. Have we seen a strong demand for this?
Member
Author
|
@raboof reasonable point about URLs in exception messages. We could make the behaviour opt-in via config (off by default). Noone has explicitly asked for this and we could just take this as a cue to leave this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #642
Copies akka/akka-grpc#1748 which is now Apache licensed