GH-506: Clarify field ordering for partially shredded object union#565
Open
nssalian wants to merge 1 commit intoapache:masterfrom
Open
GH-506: Clarify field ordering for partially shredded object union#565nssalian wants to merge 1 commit intoapache:masterfrom
nssalian wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
CC: @emkornfield |
emkornfield
reviewed
Apr 16, 2026
|
|
||
| # union the shredded fields and non-shredded fields | ||
| # (the result is a Variant object; field ID ordering rules | ||
| # from VariantEncoding.md apply) |
Contributor
There was a problem hiding this comment.
probably better to summarize them here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
construct_variantpseudocode inVariantShredding.mduses.union()without specifying result field ordering. This adds a comment cross-referencing VariantEncoding.md's requirement that object field IDs must be sorted lexicographically.I dug into the code and found that parquet-java already enforces this via
Collections.sort(fields)inVariantBuilder.endObject(), verified by TestReadVariant#testPartiallyShreddedObjectOutOfOrder.Closes #506