Minor: Clarify value_metadata in Variant value layout diagram#507
Merged
wgtmac merged 1 commit intoapache:masterfrom Jul 24, 2025
Merged
Minor: Clarify value_metadata in Variant value layout diagram#507wgtmac merged 1 commit intoapache:masterfrom
wgtmac merged 1 commit intoapache:masterfrom
Conversation
alamb
approved these changes
Jul 17, 2025
Contributor
There was a problem hiding this comment.
Thank you @douenergy -- I think this is a nice clarification (note I don't have permissions to merge to this repo so we will need to wait for a committer to approve as well)
wgtmac
approved these changes
Jul 24, 2025
Member
|
Looks good! Thanks @douenergy and @alamb! |
Contributor
|
Thank you for the merge @wgtmac |
jiayuasu
pushed a commit
to jiayuasu/parquet-format
that referenced
this pull request
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When first reading the Variant encoding spec, it can be unclear that each Variant value begins with a single
value_metadatabyte composed ofvalue_headerandbasic_type. This can be confusing, especially since “metadata” is also used to refer to the dictionary metadata structure.The spec already uses the term
value_metadatain prose, so labeling it clearly in the layout diagram helps reinforce understanding and reduce ambiguity.What changes are included in this PR?
<-- value_metadata) to the value layout diagram to explicitly indicate that the first byte isvalue_metadata.Do these changes have PoC implementations?
N/A — documentation-only change, no impact on implementations.