HDDS-14895. Improve DiskCheckUtil.checkReadWrite to tolerate not enough file handler#9973
Open
ChenSammi wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14895. Improve DiskCheckUtil.checkReadWrite to tolerate not enough file handler#9973ChenSammi wants to merge 1 commit intoapache:masterfrom
ChenSammi wants to merge 1 commit intoapache:masterfrom
Conversation
1e75901 to
8cba894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If DiskCheckUtil.checkReadWrite failed due to no open file handlers during file write, the Error type exception is not caught by checkReadWrite, so the volume will be marked as failure immediately.
This task aims to catch the exception, and if it's too many open files case, tolerate it, and don't return false result.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14895
How was this patch tested?
new unit tests
real Files.newInputStream exception
real FileUtils.newOutputStreamForceAtClose exception