HDDS-14752. ReadBlock: Close stream immediately when position >= blockLength#9946
Merged
adoroszlai merged 1 commit intoapache:masterfrom Mar 25, 2026
Merged
HDDS-14752. ReadBlock: Close stream immediately when position >= blockLength#9946adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@szetszwo can you take a look? |
szetszwo
approved these changes
Mar 23, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@ss77892 , thanks for working on this! Please see the comments inlined and below:
Performance degradation in stream GET ...
Questions on the title:
- Are you comparing two different versions? If not, let's remove "Performance degradation".
- What do you mean by "stream GET"?
How about updating the title to "Close stream immediately when position >= blockLength"?
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamBlockInputStream.java
Show resolved
Hide resolved
|
|
||
| private synchronized boolean dataAvailableToRead(int length, boolean preRead) throws IOException { | ||
| if (position >= blockLength) { | ||
| maybeReleaseStreamOnEof(); |
Contributor
There was a problem hiding this comment.
Since position is only updated in advancePosition(..) but not here, we don't have to close stream here.
ss77892
changed the title
Contributor
Author
|
@szetszwo I updated the Jira title and the commit message. By performance degradation, I mean that the larger the file you upload, the slower the performance will be. |
szetszwo
approved these changes
Mar 24, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-14752. ReadBlock: Close stream immediately when position >= blockLength
Please describe your PR in detail:
This PR fixes a stream-read resource lifecycle issue in StreamBlockInputStream by releasing the stream permit immediately at block EOF, instead of relying on delayed cleanup paths. The read position advancement was
centralized and EOF release was made explicit to ensure consistent behavior across reads.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14752
How was this patch tested?
UT has been added. Read cluster with 3 nodes performance evaluation.