HDDS-11966. Add recon support by fraochan · Pull Request #16 · apache/ozone-helm-charts

fraochan · 2024-12-15T20:08:27Z

What changes were proposed in this pull request?

This PR adds the files required for an optional Recon.

Recon does not require a persistent volume. I hesitated to do a deployment, but the Apache Ozone Git project suggests a statefulset as an example. I don't mind converting it to a deployment if you find it necessary.

What is the link to the Apache JIRA

HDDS-11966

How was this patch tested?

I created a local cluster with kind, then :

I deployed an Apache Ozone cluster with Recon:

helm install ozone ./charts/ozone --set recon.enabled=true

I waited for the datanodes to register with Recon and checked that the datanodes were listed in the Recon UI localhost:9888/#/Datanodes with a port-forward:

kubectl port-forward svc/ozone-recon 9888:9888

I created a bucket with aws-cli:

aws s3api --endpoint http://localhost:9878 create-bucket --bucket=wordcount

And I made sure that the bucket appeared here: localhost:9888/#/Buckets
And finally, I've deleted Recon

helm upgrade ozone ./charts/ozone --set recon.enabled=false

ptlrs

Thank you for the PR @fraochan. It mostly looks good. I have a few comments.

ptlrs · 2024-12-18T19:01:48Z

charts/ozone/templates/recon/recon-statefulset.yaml

+            - name: WAITFOR
+              value: {{ $.Release.Name }}-scm-0.{{ $.Release.Name }}-scm-headless:{{ .Values.scm.service.port }}


We should consider if waiting for another pod is strictly necessary.
If we do have to wait then we should do it in an initcontainer.

Also, we should use the SCM service instead of addressing the pod directly. At any point we have to consider the pod -scm-0 being down and should instead rely on other SCM pods (if any in HA mode) by using the SCM service.

I was inspired by the Apache Ozone Kubernetes examples of the source repository. But indeed, I agree with you.

Recon runs in a loop until it can communicate with the SCM headless service. In my opinion, deleting this part is enough.

Otherwise, I'll do an initContainer (although I'm not sure yet what I'll do as a check to make Recon wait, probably not too hard but I haven't thought about it yet).

charts/ozone/templates/recon/recon-service.yaml

ptlrs · 2024-12-18T19:36:07Z

charts/ozone/templates/recon/recon-statefulset.yaml

+{{- $tolerations := or .Values.recon.tolerations .Values.tolerations }}
+{{- $securityContext := or .Values.recon.securityContext .Values.securityContext }}
+apiVersion: apps/v1
+kind: StatefulSet


We should consider making this pod stateless by using a Deployment.

I should have been more confident, that was my initial suggestion. But in line with the rest of the Helm Chart, I've made it a Statefulset.

So I completely agree with you and have made the changes.

By the way, I'd say the S3 gateway is also stateless and could be a deployment, couldn't it?

charts/ozone/templates/recon/recon-statefulset.yaml

ptlrs · 2024-12-18T19:49:42Z

charts/ozone/templates/_helpers.tpl

  value: "true"
+{{- if .Values.recon.enabled }}
+- name: OZONE-SITE.XML_ozone.recon.address
+  value: {{ include "ozone.recon.pod" . }}


This should point to the Recon service name instead of the pod.
We should be able to refer to the recon pod without specifying the type of the pod. This is where the service comes into the picture.

ozone.recon.pod defined in this file above can be removed if not needed elsewhere.

I just had to add the rpc port to the service as well, but yes,we might use the service.

fraochan · 2024-12-19T22:22:12Z

@ptlrs, thanks for the constructive review, I've modified the code accordingly and I'm ready for another one :)

devmadhuu

Thanks @fraochan for the patch. Though I am not aware of internal details, but overall changes LGTM +1 for Recon ports and service deployment.

MadanDhungel · 2025-12-16T12:02:43Z

hey i would like to know when will the apache ozone officially merge and reflect these values on the branch, i am currently trying to deploy in K8s and i am unable to get svc/recon. Also any pointer will be much helpful.

adoroszlai · 2025-12-16T12:09:46Z

Thanks @MadanDhungel for pinging, sorry, I totally forgot about this.

adoroszlai · 2025-12-16T12:24:01Z

@dnskr please take a look

MadanDhungel · 2025-12-17T04:12:28Z

In the main banch i did not see any folder with name recon

in the changed files there is recon with service and development file but is not reflected to main branch, other changes were also not reflected .

is there another process or is the recon depreciated or whats going on

do i need to install ozone's recon UI from different ways .
@adoroszlai

adoroszlai · 2025-12-17T08:06:15Z

@MadanDhungel This is not yet merged. Please checkout the PR:

git fetch https://github.com/apache/ozone-helm-charts refs/pull/16/head && git checkout FETCH_HEAD

Then you can try Recon as being added by this PR. Thank you for testing it.

Madan-Dhungel · 2025-12-18T04:10:52Z

hey thanks for the info, i tried and was successful in deploying in K8s cluster, all pods are running fine with services being exposed.

Huge thanks to you @adoroszlai

adoroszlai · 2025-12-18T06:52:14Z

Thanks @fraochan for the patch (sorry for the late response), @devmadhuu, @ptlrs for the review, @Madan-Dhungel for testing it.

ptlrs reviewed Dec 18, 2024

View reviewed changes

fraochan changed the title ~~Add recon support~~ HDDS-11966. Add recon support Dec 19, 2024

Add recon support

6ce95ba

fraochan force-pushed the add-recon-sts branch from 84eb444 to 6ce95ba Compare December 19, 2024 22:08

adoroszlai requested a review from ptlrs January 31, 2025 16:19

ivandika3 requested review from devmadhuu and removed request for ptlrs July 7, 2025 01:34

devmadhuu approved these changes Jul 8, 2025

View reviewed changes

adoroszlai added 3 commits December 16, 2025 13:16

Merge remote-tracking branch 'origin/main' into add-recon-sts

309e789

update NOTES to be in line with other services

5b9e7d3

add newline at EOF

60c9ba3

adoroszlai merged commit 0463c8c into apache:main Dec 18, 2025
1 check passed

		- name: WAITFOR
		value: {{ $.Release.Name }}-scm-0.{{ $.Release.Name }}-scm-headless:{{ .Values.scm.service.port }}

Conversation

fraochan commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

ptlrs left a comment

Choose a reason for hiding this comment

Uh oh!

ptlrs Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

fraochan Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ptlrs Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

fraochan Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ptlrs Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

fraochan Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fraochan commented Dec 19, 2024

Uh oh!

devmadhuu left a comment

Choose a reason for hiding this comment

Uh oh!

MadanDhungel commented Dec 16, 2025

Uh oh!

adoroszlai commented Dec 16, 2025

Uh oh!

adoroszlai commented Dec 16, 2025

Uh oh!

MadanDhungel commented Dec 17, 2025

Uh oh!

adoroszlai commented Dec 17, 2025

Uh oh!

Madan-Dhungel commented Dec 18, 2025

Uh oh!

Uh oh!

adoroszlai commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fraochan commented Dec 15, 2024 •

edited

Loading

fraochan Dec 19, 2024 •

edited

Loading

fraochan Dec 19, 2024 •

edited

Loading