Fix multiple issues discovered via running examples #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Otava looks 1 year back. Example data is too old.
This commit fixes behavior removed in #86 - expand all env variables, not just ones matching CLI arguments. There are users relying on this behavior so we should not break it without longer discussion and a major release.
Gerrrr
changed the title
Gerrrr
changed the title
henrikingo
approved these changes
Nov 11, 2025
Contributor
henrikingo
left a comment
henrikingo
left a comment
There was a problem hiding this comment.
How did we not have expandvars? Was that the bug that we accidentally dropped it?
Contributor
Author
|
My interpretation is that #86 assumed that we only ever want to have env vars that match CLI args, which is not the case. |
Contributor
|
Some examples still don't work for me (see below) Master branch:
PR-95 (this one):
Release Apache Otava 0.7.0-incubating-rc2 (see https://lists.apache.org/thread/2dr1ccy9yb278wgxy611wz5p2ypqjhnv)
I would suggest implement the same changes for GRAPHITE, GRAPHANA examples as in 0.7.0-incubating-rc2 here. |
Contributor
|
Update: I figured out that the problem was on my side due to me building the docker container on windows. Git clone replaced line endings symbols with windows-based ones which messed with docker. |
henrikingo
pushed a commit
that referenced
this pull request
Nov 16, 2025
* Fix docker run commands in examples * Bump year in the postgres example data By default, Otava looks 1 year back. Example data is too old. * Expand all env variables and fix PostgreSQL example This commit fixes behavior removed in #86 - expand all env variables, not just ones matching CLI arguments. There are users relying on this behavior so we should not break it without longer discussion and a major release.
Contributor
Gerrrr
added a commit
that referenced
this pull request
Nov 28, 2025
* Revert "Fix multiple issues discovered via running examples (#95)" This reverts commit 5276f24. * Revert "Fix config parsing (#91)" This reverts commit 484aaef. * Revert "OTAVA-82: use ConfigArgParse to create Config (#86)" This reverts commit 69d2b97. * Fix docker run commands in examples * Bump year in the postgres example data By default, Otava looks 1 year back. Example data is too old. * Update CLI help description * Add e2e tests covering CSV and PostgreSQL usage * OTAVA-65: Fix --help requiring a config file * Run tests against branch 0.7 * Fixup csv docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to @Sowiks who noticed issues with PostgreSQL example during release vote.