Remove +incubating, add it to description and authors instead #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikingo
reviewed
Jun 5, 2025
pyproject.toml
Outdated
| authors = ["Apache Otava Developers <dev@otava.apache.org>"] | ||
| version = "0.6.0" | ||
| description = "Apache Otava (Incubating): Change Detection for Continuous Performance Engineering" | ||
| authors = ["Apache Otava (Incubating) Developers <dev@otava.apache.org>"] |
Contributor
There was a problem hiding this comment.
I would drop "Developers" but it works like this too
henrikingo
reviewed
Jun 5, 2025
| authors = ["Apache Otava (Incubating) Developers <dev@otava.apache.org>"] | ||
| include = ["DISCLAIMER"] | ||
| packages = [{include = "otava"}] | ||
| packages = [{ include = "otava" }] |
Contributor
There was a problem hiding this comment.
Since we're here... what does this do and why is this not apache-otava?
Contributor
Author
There was a problem hiding this comment.
Poetry needs this to discover the main part of the codebase. Without this, we'll need to rename https://github.com/apache/otava/tree/master/otava to apache-otava as well.
henrikingo
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.