Skip to content

Conversation

@Gerrrr
Copy link
Contributor

@Gerrrr Gerrrr commented May 9, 2025

  • The NOTICE file does not include '(Incubating)' after the podling name.
    https://github.com/apache/amoro/blob/master/NOTICE is a valid example
  • No DISCLAIMER in otava-0.6.0+incubating.tar.gz or in
    otava-0.6.0+incubating-py3-none-any.whl
  • The email address in otava-0.6.0+incubating.dist-info/METADATA (in
    the wheel file) has an individual's non Apache email address
    I think this should have an address like dev@otava.apache.org. It is
    not the ASF norm for individual's to take the credit for maintaining
    files - it is a team effort.

I would prefer if the LICENSE, NOTICE and DISCLAIMER had no .txt
suffix. This is not the norm but probably allowable.

See individual commits for each point.

Gerrrr added 4 commits May 8, 2025 21:58
This change addresses ASF feedback about individual contributor's name
and email in PKG-INFO and dist metadata.

Turns out, poetry just takes the first author from pyproject and puts
them as the only author in those files. Instead, we'll do the same as
PyArrow - https://github.com/apache/arrow/blob/2a88c5267d980851dc1dcdff54dbfe115ee1ef89/python/pyproject.toml#L49-L51.
@Gerrrr Gerrrr merged commit ee74e5f into master May 9, 2025
3 checks passed
@Gerrrr Gerrrr mentioned this pull request May 29, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants