analysis.split sorts change points before getting intervals #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, change points discovered while scanning sliding windows are added to the end of the list. At the same time, SignificanceTester.get_intervals expects change points to be sorted. As a result, intervals contain 1 or more None that cause ValueError in tester.change_point.
Contributor
|
Went over the code changes, it's an approval from me. |
Contributor
|
Now the question is, should we track our own perf test results with a dashboard and change detection? |
Contributor
Author
This would be lovely! Can we use Nyrkiö dashboard? Maybe we can start a mailing thread about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, change points discovered while scanning sliding
windows are added to the end of the list. At the same time,
SignificanceTester.get_intervals expects change points to be sorted.
As a result, intervals contain 1 or more
Nonethat causeValueErrorintester.change_point.
The second commit adds perf tests to the CI suite, so we catch this kind of bugs during PR review.