Skip to content

Conversation

@solomax
Copy link
Contributor

@solomax solomax commented Jul 4, 2025

No description provided.

@cristof
Copy link
Contributor

cristof commented Jul 4, 2025

Wouldn't it better to change the profile to test-h2-2 instead of changing the test-h2 profile to use h2-2.x version? In my forked OPENJPA-2940 branch, I 've found some other issues with the h2 and h2-2 tests.

@solomax
Copy link
Contributor Author

solomax commented Jul 4, 2025

This https://ci-builds.apache.org/job/OpenJPA/job/openjpa-pr/ build passes on this branch
I'll re-test with 1.x :)
But according to https://mvnrepository.com/artifact/com.h2database/h2 all 1.x versions are vulnerable
And latest is from 2019 .....

@cristof
Copy link
Contributor

cristof commented Jul 4, 2025

I agree we should remove h2 1.x version profiles from tests, notably because h2-2 has options to keep some of the previous syntax. If apache ci-builds work, the failed with h2-2 (and 1.x) are probably result of the bump of jdk version. Why don't you just exchange the profile for test-h2-2?

@solomax
Copy link
Contributor Author

solomax commented Jul 4, 2025

I'm currently investigating :)

Current results are:

  • my local build on derby is green
  • jenkins derby build is red
  • my local build on h2 1.x is red (need to be re-tested)
  • my local build on h2 2.x is green (in branch)
  • gh build on h2 2.x is red (on branch)
  • jenkins build h2 2.x is green (on branch)

I need to re-test above and clean-up the pr

I would liks to keep derby as default since it works locally :)

@cristof
Copy link
Contributor

cristof commented Jul 4, 2025

I'm good with derby be kept as default.
Please note that only my second run of ci builds in gh failed, so I suppose you should test it two times to be sure gh actions will really work afterwards.

@solomax solomax changed the title Switching CI to H2 DB (with DB driver update and test fix) [OPENJPA-2941] Switching CI to H2 DB (with DB driver update and test fix) Jul 9, 2025
@solomax solomax merged commit 95acfa6 into master Jul 9, 2025
0 of 2 checks passed
@solomax solomax deleted the solomax/h2-switch branch July 9, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants