[OPENJPA-2936] Fixes unnamed index synchronization #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow creation of indexes using columns names * Modified TestIndices to test creation of unnamed index
solomax
reviewed
Apr 30, 2025
Contributor
solomax
left a comment
solomax
left a comment
There was a problem hiding this comment.
LGTM! :)))
all comments are minor :))
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/MappingInfo.java
Outdated
Show resolved
Hide resolved
...sistence-jdbc/src/test/java/org/apache/openjpa/persistence/jdbc/annotations/TestIndices.java
Outdated
Show resolved
Hide resolved
...sistence-jdbc/src/test/java/org/apache/openjpa/persistence/jdbc/annotations/TestIndices.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I've just committed the code format fixing. Thanks for reviewing - I get a little confused about the brackets, as ifs without them are abundant. Hope it makes to 4.1.1 (and eventually to tomee-10). |
Contributor
|
Hello @cristof, I, personally, prefer having curly brackets even if there is one line of code inside it I'll try to push this PR as soon as Github build will succeed Sorry for the long review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on default db, h2, h2-2, postgresql.