OPENJPA-2925 - Removed stalled eager result #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks a lot @cristof , Thanks for your patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed cached result just before loading eager joins. It should not impact direct eager loading.
The cached result ignored the difference between an eager loaded entity (Cat->human) and a call to a parent who also have the same eager loaded entity (Cat->parent(Cat)->human), in the case getting the last loaded value from (Cat->parent->cats).
I tried to remove this cache in another place, but it broke multiple eager loading tests (that tested for a limit of db calls). Didn't check if there is a larger impact, though.