[OPENJPA-2933] Implements new date JPA 3.1 JPQL functions and equivalent Criteria API #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bumped jakarta persistence API to 3.1.0 * Added necessary stub impl of methods (throws UnsupportedOperationException) * Tests passes, but actual impls must be made in probably different issues, one for each new features (https://jakarta.ee/specifications/persistence/3.1/jakarta-persistence-spec-3.1#jakarta-persistence-3-1)
…EXTRACT functions * Added JPA 3.1 date/time JPQL new functions LOCAL DATE, LOCAL TIME and LOCAL DATETIME and Criteria equivalents * Added JPQL EXTRACT date/time field and EXTRACT date/time (as a CAST) JPQL functions * Added tests to verify validity of BNF changes in JPQL.jjt and each new function
* Updated round function usage and test due a corner case on postgresql tests * Made EXTRACT function test be resistent to date/time divergence between db and test environments * Updated manual BNF and Date Time functions chapters
solomax
reviewed
Feb 8, 2025
Contributor
solomax
left a comment
solomax
left a comment
There was a problem hiding this comment.
I would ask for a minor change
The PR is absolutely fantastic! Thanks for you work! :))
| switch (_field) { | ||
| case QUARTER: | ||
| int month = t.get(ChronoField.MONTH_OF_YEAR); | ||
| return (int) Math.round(Math.ceil(month/3f)); |
Contributor
There was a problem hiding this comment.
Suggested change
| return (int) Math.round(Math.ceil(month/3f)); | |
| return Math.round(month / 3f); |
should be enough here :)
Contributor
Author
There was a problem hiding this comment.
Actually, your solution gives wrong results for January(1) - gives 0, April(4) - gives 1, July (7) - gives 3, and October (10) - gives 3, because rounds 0.3 to 0 and so on.
Contributor
There was a problem hiding this comment.
My bad :(
You are right :)
The only redundant part is (int) :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented LOCAL DATE, LOCAL TIME, LOCAL DATETIME functions and criteria api equivalents
Implemented EXTRACT functions
Updated documentation
Fixed corner case of round function on postgresql (got the error when testing updated master on derbydb, h2, mariadb (11), mysql (8 and 9) and postgresql (16 and 17).
Please, don't hesitate to ask fixes (pretty sure it needs some).