[OPENJPA-2932] Implements numeric JPA 3.1 JPQL functions and equivalent Criteria API #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bumped jakarta persistence API to 3.1.0 * Added necessary stub impl of methods (throws UnsupportedOperationException) * Tests passes, but actual impls must be made in probably different issues, one for each new features (https://jakarta.ee/specifications/persistence/3.1/jakarta-persistence-spec-3.1#jakarta-persistence-3-1)
…nt Criteria API * Implements CEILING, EXP, FLOOR, SIGN, LN, POWER and ROUND JPQL functions * Ajusts JPQL.jjt * Added kernel and jdbc equivalent expressions * Added one test for each new expression in JPQL and Criteria API * Updates manual page referring new FUNCTIONS * Added DatabaseHelper to add necessary functions on DerbyDb (it does not natively support POWER and ROUND functions)
solomax
reviewed
Jan 24, 2025
Contributor
solomax
left a comment
solomax
left a comment
There was a problem hiding this comment.
My comments are minor
PR looks very good! :))
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/Ceiling.java
Show resolved
Hide resolved
openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/Ceiling.java
Show resolved
Hide resolved
openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/Ceiling.java
Outdated
Show resolved
Hide resolved
openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/Floor.java
Outdated
Show resolved
Hide resolved
...jpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/CriteriaTest.java
Outdated
Show resolved
Hide resolved
* Minor style fixing on ifs * Removing unused import statements in test
Contributor
Author
|
Fixed issues on fork. Please review again. |
solomax
requested changes
Feb 2, 2025
Contributor
solomax
left a comment
solomax
left a comment
There was a problem hiding this comment.
I believe one TODO item need to be addressed :)
openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/InMemoryExpressionFactory.java
Outdated
Show resolved
Hide resolved
...rsistence-jdbc/src/test/java/org/apache/openjpa/persistence/common/utils/DatabaseHelper.java
Outdated
Show resolved
Hide resolved
...ence-jdbc/src/test/java/org/apache/openjpa/persistence/jpql/functions/TestEJBQLFunction.java
Show resolved
Hide resolved
* Addressing doubts on instrumental creation of derbdb functions * Fixing InMemoryExpressionFactory missing TODO
solomax
approved these changes
Feb 2, 2025
Contributor
|
Thanks a million for the contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPENJPA-2932