NUTCH-3136 Upgrade crawler-commons dependency #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robots.txt parser: use URL objects in newly introduced methods to avoid the unnecessary parsing of URLs.
Update URLUtil test to adapt to a change in the public suffix list
sebastian-nagel
force-pushed
the
upgrade-crawler-commons-1.6
branch
from
3815d13 to
080c2c1
Compare
lewismc
approved these changes
Dec 18, 2025
Member
lewismc
left a comment
lewismc
left a comment
There was a problem hiding this comment.
+1 good addition of tests. Very specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.